Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 23483022: Added a "Skip" expectation to allow test runs to avoid known timeouts (Closed)

Created:
7 years, 3 months ago by bajones
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Added a "Skip" expectation to allow test runs to avoid known timeouts Some tests are known to timeout, or fail after stalling for a long time. In those cases setting the test expectation to "Fail" will enable the tests to pass sucessfully, but the test may take much longer than necessary. By skipping the long-running failure cases test time can be drastically reduced in some cases. BUG=280750 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220493

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools/telemetry/telemetry/page/page_runner.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/test_expectations.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bajones
7 years, 3 months ago (2013-08-29 21:49:38 UTC) #1
Ken Russell (switch to Gerrit)
I'd like to see this get in because there are some buggy WebGL conformance tests ...
7 years, 3 months ago (2013-08-29 22:04:40 UTC) #2
dtu
lgtm
7 years, 3 months ago (2013-08-29 22:21:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/23483022/1
7 years, 3 months ago (2013-08-29 22:26:31 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, chromedriver2_unittests, ...
7 years, 3 months ago (2013-08-29 22:51:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/23483022/39001
7 years, 3 months ago (2013-08-29 23:10:31 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 03:18:11 UTC) #7
Message was sent while issue was closed.
Change committed as 220493

Powered by Google App Engine
This is Rietveld 408576698