Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 23483022: Added a "Skip" expectation to allow test runs to avoid known timeouts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/test_expectations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index dff83ef5e056d51fc73cbd02297ebd346921d5a2..de0ebffc82bc9513000be2fd80347580a3260e2b 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -367,6 +367,10 @@ def _CheckArchives(page_set, pages, results):
def _RunPage(test, page, state, expectation, results, finder_options):
+ if expectation == 'skip':
+ logging.warning('Skipped %s' % page.url)
+ return
+
logging.info('Running %s' % page.url)
page_state = PageState()
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/test_expectations.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698