silence the error test to be a better citizen

silence the error test to be a better citizen

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=11409

[caryclark, 2013-09-11 18:25:48]

lgtm

[commit-bot: I haz the power, 2013-09-11 19:33:18]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/humper@google.com/23481012/1

[tfarina, 2013-09-11 19:39:24]

https://codereview.chromium.org/23481012/diff/1/tests/ErrorTest.cpp
File tests/ErrorTest.cpp (right):

https://codereview.chromium.org/23481012/diff/1/tests/ErrorTest.cpp#newcode13
tests/ErrorTest.cpp:13: typedef struct {
typedef should not be necessary here as we compile with C++ rather than C.

https://codereview.chromium.org/23481012/diff/1/tests/ErrorTest.cpp#newcode13
tests/ErrorTest.cpp:13: typedef struct {
I think this can be simply:

struct ErrorContext {
};

unless I'm missing something.

https://codereview.chromium.org/23481012/diff/1/tests/ErrorTest.cpp#newcode16
tests/ErrorTest.cpp:16: } ErrorContext;
this is creating a variable as far as I can see. Do you need this?

[commit-bot: I haz the power, 2013-09-11 19:44:48]

Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for
step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests,
BuildTools
http://173.255.115.253:10117/buildstatus?builder=Build-Ubuntu12-GCC-x86_64-Re...

[mtklein, 2013-09-11 20:51:18]

https://codereview.chromium.org/23481012/diff/1/tests/ErrorTest.cpp
File tests/ErrorTest.cpp (right):

https://codereview.chromium.org/23481012/diff/1/tests/ErrorTest.cpp#newcode16
tests/ErrorTest.cpp:16: } ErrorContext;
On 2013/09/11 19:39:25, tfarina wrote:
> this is creating a variable as far as I can see. Do you need this?

Oh how I love C++ syntax!

typedef struct { ... } Foo;

makes a type Foo which is a struct, as if you'd written

struct Foo { ... };

on the other hand, visually similar

struct { ... } Foo;

makes a variable Foo whose type is an anonymous struct.

But, yeah, C++ generally would write

struct ErrorContext {
    skiatest::Reporter *fReporter;
    unsigned int *fIntPointer;
};

[commit-bot: I haz the power, 2013-09-19 21:44:46]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/humper@google.com/23481012/13001

[commit-bot: I haz the power, 2013-09-19 22:11:41]

Change committed as 11409