Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: tests/ErrorTest.cpp

Issue 23481012: silence the error test to be a better citizen (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Silence 2nd instance of same error Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/SkGpuDevice.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/ErrorTest.cpp
diff --git a/tests/ErrorTest.cpp b/tests/ErrorTest.cpp
index 761f8bf66f7ffc20951f343d15f9f7343dc24d1e..5b928085071c026748bbab020736b9b3cb5e10ce 100644
--- a/tests/ErrorTest.cpp
+++ b/tests/ErrorTest.cpp
@@ -10,21 +10,32 @@
#include "SkPath.h"
#include "SkRect.h"
+typedef struct {
+ skiatest::Reporter *fReporter;
+ unsigned int *fIntPointer;
+} ErrorContext;
+
#define CHECK(errcode) \
REPORTER_ASSERT( reporter, (err = SkGetLastError()) == errcode); \
if (err != kNoError_SkError) \
{ \
- SkDebugf("Last error string: %s\n", SkGetLastErrorString()); \
SkClearLastError(); \
}
static void cb(SkError err, void *context) {
- int *context_ptr = static_cast<int *>(context);
- SkDebugf("CB (0x%x): %s\n", *context_ptr, SkGetLastErrorString());
+ ErrorContext *context_ptr = static_cast<ErrorContext *>(context);
+ REPORTER_ASSERT( context_ptr->fReporter, (*(context_ptr->fIntPointer) == 0xdeadbeef) );
}
static void ErrorTest(skiatest::Reporter* reporter) {
SkError err;
+
+ unsigned int test_value = 0xdeadbeef;
+ ErrorContext context;
+ context.fReporter = reporter;
+ context.fIntPointer = &test_value;
+
+ SkSetErrorCallback(cb, &context);
CHECK(kNoError_SkError);
@@ -43,19 +54,10 @@ static void ErrorTest(skiatest::Reporter* reporter) {
CHECK(kInvalidArgument_SkError);
CHECK(kNoError_SkError);
- int test_value = 0xdeadbeef;
- SkSetErrorCallback(cb, &test_value);
-
// should trigger *our* callback.
path.addRoundRect(r, -10, -10);
CHECK(kInvalidArgument_SkError);
CHECK(kNoError_SkError);
-
- // Should trigger the default one again.
- SkSetErrorCallback(NULL, NULL);
- path.addRoundRect(r, -10, -10);
- CHECK(kInvalidArgument_SkError);
- CHECK(kNoError_SkError);
}
#include "TestClassDef.h"
« no previous file with comments | « src/gpu/SkGpuDevice.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698