Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 23480048: Remove the problematic call to GLSurface::GetBackingFrameBufferObject. (Closed)

Created:
7 years, 3 months ago by msimonides
Modified:
7 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org, apatrick_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove the problematic call to GLSurface::GetBackingFrameBufferObject. GLContextVirtual::IsCurrent doesn't need to call GetBackingFrameBufferObject on a surface, the IsOffScreen check should be enough. The direct reason for this change is that GLContextVirtual::IsCurrent's use of GetBackingFrameBufferObject interferes with the implementation of that function in TextureImageTransportSurface. TextureImageTransportSurface::GetBackingFrameBufferObject creates an FBO if needed. Unfortunately GLContextVirtual::IsCurrent is called early in GLContextVirtual's initialization, too early for TextureImageTransportSurface::GetBackingFrameBufferObject to create the frame buffer object because it needs a fully initialized context to succeed. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222505

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M gpu/command_buffer/service/gl_context_virtual.cc View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 11 (0 generated)
msimonides
7 years, 3 months ago (2013-09-09 08:49:33 UTC) #1
no sievers
lgtm https://codereview.chromium.org/23480048/diff/1/gpu/command_buffer/service/gl_context_virtual.cc File gpu/command_buffer/service/gl_context_virtual.cc (right): https://codereview.chromium.org/23480048/diff/1/gpu/command_buffer/service/gl_context_virtual.cc#newcode73 gpu/command_buffer/service/gl_context_virtual.cc:73: if (surface && nit: I think this fits ...
7 years, 3 months ago (2013-09-09 17:04:12 UTC) #2
piman
lgtm
7 years, 3 months ago (2013-09-09 21:08:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msimonides@opera.com/23480048/1
7 years, 3 months ago (2013-09-10 05:50:50 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=167220
7 years, 3 months ago (2013-09-10 07:27:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msimonides@opera.com/23480048/1
7 years, 3 months ago (2013-09-10 07:51:56 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=167274
7 years, 3 months ago (2013-09-10 08:36:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msimonides@opera.com/23480048/1
7 years, 3 months ago (2013-09-10 09:01:56 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=167331
7 years, 3 months ago (2013-09-10 09:57:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msimonides@opera.com/23480048/1
7 years, 3 months ago (2013-09-11 07:57:30 UTC) #10
commit-bot: I haz the power
7 years, 3 months ago (2013-09-11 12:10:53 UTC) #11
Message was sent while issue was closed.
Change committed as 222505

Powered by Google App Engine
This is Rietveld 408576698