Support creating secure decoder in MediaCodecBridge.

Support creating secure decoder in MediaCodecBridge.

BUG=163552
TEST=L1 doesn't fully work due to mediaDrm issues. L3 still works well.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221906

[xhwang, 2013-09-05 21:27:59]

I still need to test this CL. Please take a quick look to see if the approach is
okay. Thanks!

https://codereview.chromium.org/23480036/diff/1/content/browser/android/brows...
File content/browser/android/browser_media_player_manager.cc (right):

https://codereview.chromium.org/23480036/diff/1/content/browser/android/brows...
content/browser/android/browser_media_player_manager.cc:519:
MediaDrmBridge::Create(media_keys_id, uuid, "L1", this));
I'll revert this change after the test is done.

[qinmin, 2013-09-05 22:15:31]

https://codereview.chromium.org/23480036/diff/1/media/base/android/java/src/o...
File media/base/android/java/src/org/chromium/media/MediaDrmBridge.java (right):

https://codereview.chromium.org/23480036/diff/1/media/base/android/java/src/o...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:134: * Create
a new from the crypto scheme UUID.
s/new/new MediaDrmBridge/

https://codereview.chromium.org/23480036/diff/1/media/base/android/java/src/o...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:155:
Log.e(TAG, "Failed to set DRM properties: " + e.toString());
There is no set DRM properties call inside this function. I think you can split
MediaDrmBridge ctor into a ctor and Initialize() function. This call will return
null if either one fails.

https://codereview.chromium.org/23480036/diff/1/media/base/android/media_drm_...
File media/base/android/media_drm_bridge.cc (right):

https://codereview.chromium.org/23480036/diff/1/media/base/android/media_drm_...
media/base/android/media_drm_bridge.cc:224: j_media_drm_.Reset();
ScopedJavaGlobalRef will do this for you

https://codereview.chromium.org/23480036/diff/1/media/base/android/media_sour...
File media/base/android/media_source_player.cc (right):

https://codereview.chromium.org/23480036/diff/1/media/base/android/media_sour...
media/base/android/media_source_player.cc:587: bool is_secure =
drm_bridge_->IsProtectedSurfaceRequired();
you need to null check drm_bridge_ here.

[xhwang, 2013-09-06 02:17:47]

https://codereview.chromium.org/23480036/diff/1/media/base/android/java/src/o...
File media/base/android/java/src/org/chromium/media/MediaDrmBridge.java (right):

https://codereview.chromium.org/23480036/diff/1/media/base/android/java/src/o...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:134: * Create
a new from the crypto scheme UUID.
On 2013/09/05 22:15:31, qinmin wrote:
> s/new/new MediaDrmBridge/

Not sure how I changed this. Reverted.

https://codereview.chromium.org/23480036/diff/1/media/base/android/java/src/o...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:155:
Log.e(TAG, "Failed to set DRM properties: " + e.toString());
On 2013/09/05 22:15:31, qinmin wrote:
> There is no set DRM properties call inside this function. I think you can
split
> MediaDrmBridge ctor into a ctor and Initialize() function. This call will
return
> null if either one fails.

How about changing this error message?

https://codereview.chromium.org/23480036/diff/1/media/base/android/media_drm_...
File media/base/android/media_drm_bridge.cc (right):

https://codereview.chromium.org/23480036/diff/1/media/base/android/media_drm_...
media/base/android/media_drm_bridge.cc:224: j_media_drm_.Reset();
On 2013/09/05 22:15:31, qinmin wrote:
> ScopedJavaGlobalRef will do this for you

Done.

https://codereview.chromium.org/23480036/diff/1/media/base/android/media_sour...
File media/base/android/media_source_player.cc (right):

https://codereview.chromium.org/23480036/diff/1/media/base/android/media_sour...
media/base/android/media_source_player.cc:587: bool is_secure =
drm_bridge_->IsProtectedSurfaceRequired();
On 2013/09/05 22:15:31, qinmin wrote:
> you need to null check drm_bridge_ here.

Use IsProtectedSurfaceRequired() here which checks drm_bridge_ internally.

[qinmin, 2013-09-06 03:28:53]

lgtm

[commit-bot: I haz the power, 2013-09-07 00:45:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/23480036/17001

[commit-bot: I haz the power, 2013-09-07 01:19:33]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-07 01:30:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/23480036/45001

[commit-bot: I haz the power, 2013-09-07 07:09:03]

Change committed as 221906

[johnme, 2013-09-09 15:03:29]

On 2013/09/07 07:09:03, I haz the power (commit-bot) wrote:
> Change committed as 221906

This broke MediaSourcePlayerTest.CanPlayType_Widevine. See
http://crbug.com/287817.