Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: media/base/android/media_drm_bridge.cc

Issue 23480036: Support creating secure decoder in MediaCodecBridge. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/android/media_drm_bridge.h ('k') | media/base/android/media_source_player.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_drm_bridge.cc
diff --git a/media/base/android/media_drm_bridge.cc b/media/base/android/media_drm_bridge.cc
index d529977c052b7ded74e3ba5dee421707786cd328..d423efc10b88bb4a236b9aa349878f13f949608c 100644
--- a/media/base/android/media_drm_bridge.cc
+++ b/media/base/android/media_drm_bridge.cc
@@ -152,16 +152,22 @@ static MediaDrmBridge::SecurityLevel GetSecurityLevelFromString(
}
// static
-MediaDrmBridge* MediaDrmBridge::Create(int media_keys_id,
- const std::vector<uint8>& scheme_uuid,
- const std::string& security_level,
- MediaPlayerManager* manager) {
- if (!IsAvailable() || scheme_uuid.empty())
- return NULL;
-
- // TODO(qinmin): check whether the uuid is valid.
- return new MediaDrmBridge(
- media_keys_id, scheme_uuid, security_level, manager);
+scoped_ptr<MediaDrmBridge> MediaDrmBridge::Create(
+ int media_keys_id,
+ const std::vector<uint8>& scheme_uuid,
+ const std::string& security_level,
+ MediaPlayerManager* manager) {
+ scoped_ptr<MediaDrmBridge> media_drm_bridge;
+
+ if (IsAvailable() && !scheme_uuid.empty()) {
+ // TODO(qinmin): check whether the uuid is valid.
+ media_drm_bridge.reset(
+ new MediaDrmBridge(media_keys_id, scheme_uuid, security_level, manager));
+ if (media_drm_bridge->j_media_drm_.is_null())
+ media_drm_bridge.reset();
+ }
+
+ return media_drm_bridge.Pass();
}
// static
@@ -213,7 +219,8 @@ MediaDrmBridge::MediaDrmBridge(int media_keys_id,
MediaDrmBridge::~MediaDrmBridge() {
JNIEnv* env = AttachCurrentThread();
- Java_MediaDrmBridge_release(env, j_media_drm_.obj());
+ if (!j_media_drm_.is_null())
+ Java_MediaDrmBridge_release(env, j_media_drm_.obj());
}
bool MediaDrmBridge::GenerateKeyRequest(const std::string& type,
« no previous file with comments | « media/base/android/media_drm_bridge.h ('k') | media/base/android/media_source_player.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698