Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 23477070: Move OnFileSystemMounted/BeingUnmounted to VolumeManager. (Closed)

Created:
7 years, 3 months ago by hidehiko
Modified:
7 years, 3 months ago
Reviewers:
kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move OnFileSystemMounted/BeingUnmounted to VolumeManager. By this CL, Drive's mounting state is managed by VolumeManager. So, now EventRouter needs to listen only VolumeManager to report "mounting" state update. Along with the change, the responsibility to create DriveIntegrationService is moved to VolumeManager from EventRouter. BUG=279276 TEST=Ran unit_tests and tested manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223029

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -57 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/event_router.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 4 chunks +18 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.h View 6 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 6 chunks +44 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager_factory.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager_unittest.cc View 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 3 months ago (2013-09-12 10:41:46 UTC) #1
kinaba
lgtm
7 years, 3 months ago (2013-09-13 03:19:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23477070/5001
7 years, 3 months ago (2013-09-13 07:34:43 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 11:54:23 UTC) #4
Message was sent while issue was closed.
Change committed as 223029

Powered by Google App Engine
This is Rietveld 408576698