Issue 23477070: Move OnFileSystemMounted/BeingUnmounted to VolumeManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23477070: Move OnFileSystemMounted/BeingUnmounted to VolumeManager. (Closed)

Created:
7 years, 3 months ago by hidehiko

Modified:
7 years, 3 months ago

Reviewers:
kinaba

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move OnFileSystemMounted/BeingUnmounted to VolumeManager. By this CL, Drive's mounting state is managed by VolumeManager. So, now EventRouter needs to listen only VolumeManager to report "mounting" state update. Along with the change, the responsibility to create DriveIntegrationService is moved to VolumeManager from EventRouter. BUG=279276 TEST=Ran unit_tests and tested manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223029

Patch Set 1 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+113 lines, -57 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager/event_router.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/event_router.cc	View	4 chunks	+18 lines, -30 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/file_manager/volume_manager.h	View	6 chunks	+12 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/file_manager/volume_manager.cc	View	6 chunks	+44 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/file_manager/volume_manager_factory.cc	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/file_manager/volume_manager_unittest.cc	View	2 chunks	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23477070/5001

7 years, 3 months ago (2013-09-13 07:34:43 UTC) #3

Message was sent while issue was closed.

Change committed as 223029

Expand Messages | Collapse Messages