Telemetry: fix permission check when setting Android command line.

Telemetry: fix permission check when setting Android command line.

This is to fix a bug introduced by r221426 on the WebView telemetry bot.
The issue was related to the fact that ls -l can return no output if the
target folder exists but is empty.
This change makes the IsProtectedFile logic inside _SetCommandLineFile
more reliable, introducing the IsFileWritableOnDevice method in adb
commands.

BUG=284468
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222349

[Primiano Tucci (use gerrit), 2013-09-10 14:47:47]

https://codereview.chromium.org/23477053/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
(right):

https://codereview.chromium.org/23477053/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:216:
return False
I think / is not user-writable in Android.

[Primiano Tucci (use gerrit), 2013-09-10 14:53:09]

Tony, can you please take a look?

[Dominik Grewe, 2013-09-10 15:02:14]

You may also want to add an owner for build/android/pylib/android_commands.py

https://codereview.chromium.org/23477053/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
(right):

https://codereview.chromium.org/23477053/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:216:
return False
On 2013/09/10 14:47:47, Primiano Tucci wrote:
> I think / is not user-writable in Android.

That's why it should return True, because the file is protected, right?

[Primiano Tucci (use gerrit), 2013-09-10 15:20:04]

Ops, I didn't realize we have a local owner for both in the same timezone... two
desks away :)

https://codereview.chromium.org/23477053/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
(right):

https://codereview.chromium.org/23477053/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:216:
return False
On 2013/09/10 15:02:15, Dominik Grewe wrote:
> On 2013/09/10 14:47:47, Primiano Tucci wrote:
> > I think / is not user-writable in Android.
> 
> That's why it should return True, because the file is protected, right?
Oh right! My bad, I was reasoning in the inverse logic (thinking about
isWritable) :)
Thanks for the catch.

[Dominik Grewe, 2013-09-10 15:24:57]

LGTM. Thanks for fixing this.

[bulach, 2013-09-10 15:29:15]

lgtm, thanks!

[tonyg, 2013-09-10 15:44:29]

lgtm

https://codereview.chromium.org/23477053/diff/7001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
(right):

https://codereview.chromium.org/23477053/diff/7001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:210:
return not self._adb.Adb().IsFileWritableOnDevice(name)
You can either drop the .Adb() or the wrapper that you added in adb_commands.py

[commit-bot: I haz the power, 2013-09-10 17:26:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/primiano@chromium.org/23477053/14001

[commit-bot: I haz the power, 2013-09-10 20:43:57]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[Primiano Tucci (use gerrit), 2013-09-10 21:30:33]

Commit queue failing (how new?) on linux_aura for unrelated reasons. All other
bots green.
Adding NOTRY.

[commit-bot: I haz the power, 2013-09-10 21:31:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/primiano@chromium.org/23477053/14001

[commit-bot: I haz the power, 2013-09-10 21:36:20]

Change committed as 222349