tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py - Issue 23477053: Telemetry: fix permission check when setting Android command line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

Issue 23477053: Telemetry: fix permission check when setting Android command line. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove wrapper method from adb_commands Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

index a0d6dcc7e0f58ac21f16d7f5c2c789f5833c5e15..09d21c54bc5f9e044a0a61dc55baa1f1275943dc 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py

@@ -207,9 +207,7 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

def _SetCommandLineFile(self, file_contents):

def IsProtectedFile(name):

if self._adb.Adb().FileExistsOnDevice(name):

- ls_output = self._adb.RunShellCommand('ls -l %s' % name)[0]

- return ls_output == 'opendir failed, Permission denied' or \

- ls_output.split()[1] == 'root'

+ return not self._adb.Adb().IsFileWritableOnDevice(name)

else:

parent_name = os.path.dirname(name)

if parent_name != '':

« no previous file with comments | « build/android/pylib/android_commands.py ('k') | no next file » | no next file with comments »