Issue 23477044: [rAC, OSX] Fix loading screen layering issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23477044: [rAC, OSX] Fix loading screen layering issue. (Closed)

Created:
7 years, 3 months ago by groby-ooo-7-16

Modified:
7 years, 3 months ago

Reviewers:
sail

CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[rAC, OSX] Fix loading screen layering issue. The "loading..." shield on OSX had the currently focused UI element "shine through" - i.e. the entire dialog was hidden behind it except for the one focused element. This change makes the loading screen first responder for the duration of its visibility, preventing focus rings. R=sail@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221862

Patch Set 1 #

Patch Set 2 : Now with grammatically correct comments, too. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm	View	1	1 chunk	+14 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/23477044/3001

7 years, 3 months ago (2013-09-06 21:09:34 UTC) #3

Message was sent while issue was closed.

Change committed as 221862

Expand Messages | Collapse Messages