[rAC, OSX] Fix loading screen layering issue.

chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h"
 
 #include "base/bind.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 435 matching lines @@
   autofillDialog_->PerformClose();
 }
 
 - (void)updateNotificationArea {
   [mainContainer_ updateNotificationArea];
 }
 
 - (void)updateAccountChooser {
   [accountChooser_ update];
   [mainContainer_ updateLegalDocuments];
-  // TODO(estade): replace this with a better loading image/animation.
-  // See http://crbug.com/230932
+
   NSString* newLoadingMessage = @"";
   if (autofillDialog_->delegate()->ShouldShowSpinner())
     newLoadingMessage = l10n_util::GetNSStringWithFixup(IDS_TAB_LOADING_TITLE);
   if (![newLoadingMessage isEqualToString:
        [loadingShieldTextField_ stringValue]]) {
+    NSView* loadingShieldView = [loadingShieldTextField_ superview];
     [loadingShieldTextField_ setStringValue:newLoadingMessage];
     [loadingShieldTextField_ sizeToFit];
-    [[loadingShieldTextField_ superview] setHidden:
-        [newLoadingMessage length] == 0];
+    [loadingShieldView setHidden:[newLoadingMessage length] == 0];
+
+    // For the duration of the loading shield, it becomes first responder.
+    // This prevents the currently focused text field "shining through".
+    if (![loadingShieldView isHidden]) {
+      [loadingShieldView setNextResponder:
+          [[loadingShieldView window] firstResponder]];
+      [[loadingShieldView window] makeFirstResponder:loadingShieldView];
+    } else {
+      [[loadingShieldView window] makeFirstResponder:
+          [loadingShieldView nextResponder]];
+    }
     [self requestRelayout];
   }
 }
 
 - (void)updateButtonStrip {
   [overlayController_ updateState];
 }
 
 - (void)updateSection:(autofill::DialogSection)section {
   [[mainContainer_ sectionForId:section] update];
@@ skipping 52 matching lines @@
 }
 
 - (void)activateFieldForInput:(const autofill::DetailInput&)input {
   for (size_t i = autofill::SECTION_MIN; i <= autofill::SECTION_MAX; ++i) {
     autofill::DialogSection section = static_cast<autofill::DialogSection>(i);
     [[mainContainer_ sectionForId:section] activateFieldForInput:input];
   }
 }
 
 @end