Implement GetAudioOutputDevices for remaining platforms, consolidate tests.

Implement GetAudioOutputDevices for remaining platforms, consolidate tests.

For Android and Cras, returning just the default device matches
current behavior for input devices, although this may need to be
improved in the future. For OpenBSD, the current code seems to rely on
the device names list being empty, so just removing the NOTREACHED() in
AudioManagerBase's empty implementation does the trick there.

Note that audio_input_device_unittest.cc really should be named
audio_manager_unittest.cc since AudioManager is the interface it tests.
I will do this rename in a separate follow-up change to better
preserve change history.

TBR=vrk@chromium.org
BUG=276894
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223342

[Jói, 2013-09-12 11:01:49]

Note that this subsumes https://codereview.chromium.org/23475026/ and
https://codereview.chromium.org/23723009/ (the Android and Cras implementations)
which were already reviewed.

Cheers,
Jói

[tommi (sloooow) - chröme, 2013-09-12 20:46:06]

lgtm

[commit-bot: I haz the power, 2013-09-12 21:17:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/23475037/10001

[commit-bot: I haz the power, 2013-09-12 21:17:55]

Failed to apply patch for media/audio/android/audio_manager_android.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file media/audio/android/audio_manager_android.h
  Hunk #1 FAILED at 18.
  1 out of 1 hunk FAILED -- saving rejects to file
media/audio/android/audio_manager_android.h.rej

Patch:       media/audio/android/audio_manager_android.h
Index: media/audio/android/audio_manager_android.h
diff --git a/media/audio/android/audio_manager_android.h
b/media/audio/android/audio_manager_android.h
index
ba5bed61e365649b7b2b440410f64fa320bb33d7..945d1f86593673730287489b30eaf6951931c223
100644
--- a/media/audio/android/audio_manager_android.h
+++ b/media/audio/android/audio_manager_android.h
@@ -18,7 +18,9 @@ class MEDIA_EXPORT AudioManagerAndroid : public
AudioManagerBase {
   // Implementation of AudioManager.
   virtual bool HasAudioOutputDevices() OVERRIDE;
   virtual bool HasAudioInputDevices() OVERRIDE;
-  virtual void GetAudioInputDeviceNames(media::AudioDeviceNames* device_names)
+  virtual void GetAudioInputDeviceNames(AudioDeviceNames* device_names)
+      OVERRIDE;
+  virtual void GetAudioOutputDeviceNames(AudioDeviceNames* device_names)
       OVERRIDE;
   virtual AudioParameters GetInputStreamParameters(
       const std::string& device_id) OVERRIDE;

[Jói, 2013-09-16 11:49:10]

I've merged to LKGR and used static instead of the anonymous namespaces in a
couple of .cc files.

Pulling the CQ trigger now.

Cheers,
Jói

[commit-bot: I haz the power, 2013-09-16 11:49:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/23475037/15001

[commit-bot: I haz the power, 2013-09-16 12:01:30]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Jói, 2013-09-16 12:06:34]

TBR=vrk@chromium.org for removal of a deleted source file from media.gyp

[commit-bot: I haz the power, 2013-09-16 12:06:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/23475037/15001

[commit-bot: I haz the power, 2013-09-16 15:17:44]

Change committed as 223342