Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: media/audio/audio_manager_unittest.cc

Issue 23475037: Implement GetAudioOutputDevices for remaining platforms, consolidate tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Merge LKGR, remove anonymous namespaces. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_manager_base.cc ('k') | media/audio/cras/audio_manager_cras.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_manager_unittest.cc
diff --git a/media/audio/audio_manager_unittest.cc b/media/audio/audio_manager_unittest.cc
deleted file mode 100644
index 96300c9a83fdf4cd628905b17b6588de0363283d..0000000000000000000000000000000000000000
--- a/media/audio/audio_manager_unittest.cc
+++ /dev/null
@@ -1,145 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/logging.h"
-#include "base/memory/scoped_ptr.h"
-#include "media/audio/audio_manager.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-#if defined(OS_LINUX)
-#include "media/audio/linux/audio_manager_linux.h"
-#endif // defined(OS_LINUX)
-
-#if defined(OS_WIN)
-#include "media/audio/win/audio_manager_win.h"
-#endif // defined(OS_WIN)
-
-#if defined(USE_PULSEAUDIO)
-#include "media/audio/pulse/audio_manager_pulse.h"
-#endif // defined(USE_PULSEAUDIO)
-
-namespace media {
-
-void GetAudioOutputDeviceNamesImpl(AudioManager* audio_manager) {
- AudioDeviceNames device_names;
- audio_manager->GetAudioOutputDeviceNames(&device_names);
-
- VLOG(2) << "Got " << device_names.size() << " audio output devices.";
- for (AudioDeviceNames::iterator it = device_names.begin();
- it != device_names.end();
- ++it) {
- EXPECT_FALSE(it->unique_id.empty());
- EXPECT_FALSE(it->device_name.empty());
- VLOG(2) << "Device ID(" << it->unique_id << "), label: " << it->device_name;
- }
-}
-
-// So that tests herein can be friends of AudioManagerWin.
-//
-// TODO(joi): Make this go away by unifying audio_manager_unittest.cc
-// and audio_input_device_unittest.cc
-class AudioManagerTest : public ::testing::Test {
- public:
- bool SetupForSecondTest(AudioManager* amw) {
-#if defined(OS_WIN)
- AudioManagerWin* audio_manager_win = static_cast<AudioManagerWin*>(amw);
- if (audio_manager_win->enumeration_type() ==
- AudioManagerWin::kWaveEnumeration) {
- // This will be true only if running on Windows XP.
- VLOG(2) << "AudioManagerWin on WinXP; nothing more to test.";
- } else {
- VLOG(2) << "Testing AudioManagerWin in fallback WinXP mode.";
- audio_manager_win->SetEnumerationType(AudioManagerWin::kWaveEnumeration);
- return true;
- }
-#endif // defined(OS_WIN)
- return false;
- }
-};
-
-TEST_F(AudioManagerTest, GetAudioOutputDeviceNames) {
- // On Linux, we may be able to test both the Alsa and Pulseaudio
- // versions of the audio manager.
-#if defined(USE_PULSEAUDIO)
- {
- VLOG(2) << "Testing AudioManagerPulse.";
- scoped_ptr<AudioManager> pulse_audio_manager(AudioManagerPulse::Create());
- if (pulse_audio_manager.get())
- GetAudioOutputDeviceNamesImpl(pulse_audio_manager.get());
- else
- LOG(WARNING) << "No pulseaudio on this system.";
- }
-#endif // defined(USE_PULSEAUDIO)
-#if defined(USE_ALSA)
- {
- VLOG(2) << "Testing AudioManagerLinux.";
- scoped_ptr<AudioManager> alsa_audio_manager(new AudioManagerLinux());
- GetAudioOutputDeviceNamesImpl(alsa_audio_manager.get());
- }
-#endif // defined(USE_ALSA)
-
-#if defined(OS_MACOSX)
- VLOG(2) << "Testing platform-default AudioManager.";
- scoped_ptr<AudioManager> audio_manager(AudioManager::Create());
- GetAudioOutputDeviceNamesImpl(audio_manager.get());
-#endif // defined(OS_MACOSX)
-
-#if defined(OS_WIN)
- {
- // TODO(joi): Unify the tests in audio_input_device_unittest.cc
- // with the tests in this file, and reuse the Windows-specific
- // bits from that file.
- VLOG(2) << "Testing AudioManagerWin in its default mode.";
- scoped_ptr<AudioManager> audio_manager_win(AudioManager::Create());
- GetAudioOutputDeviceNamesImpl(audio_manager_win.get());
-
- if (SetupForSecondTest(audio_manager_win.get())) {
- GetAudioOutputDeviceNamesImpl(audio_manager_win.get());
- }
- }
-#endif // defined(OS_WIN)
-}
-
-TEST_F(AudioManagerTest, GetDefaultOutputStreamParameters) {
-#if defined(OS_WIN) || defined(OS_MACOSX)
- scoped_ptr<AudioManager> audio_manager(AudioManager::Create());
- ASSERT_TRUE(audio_manager);
- if (!audio_manager->HasAudioOutputDevices())
- return;
-
- AudioParameters params = audio_manager->GetDefaultOutputStreamParameters();
- EXPECT_TRUE(params.IsValid());
-#endif // defined(OS_WIN) || defined(OS_MACOSX)
-}
-
-TEST_F(AudioManagerTest, GetAssociatedOutputDeviceID) {
-#if defined(OS_WIN) || defined(OS_MACOSX)
- scoped_ptr<AudioManager> audio_manager(AudioManager::Create());
- ASSERT_TRUE(audio_manager);
- if (!audio_manager->HasAudioOutputDevices() ||
- !audio_manager->HasAudioInputDevices()) {
- return;
- }
-
- AudioDeviceNames device_names;
- audio_manager->GetAudioInputDeviceNames(&device_names);
- bool found_an_associated_device = false;
- for (AudioDeviceNames::iterator it = device_names.begin();
- it != device_names.end();
- ++it) {
- EXPECT_FALSE(it->unique_id.empty());
- EXPECT_FALSE(it->device_name.empty());
- std::string output_device_id(
- audio_manager->GetAssociatedOutputDeviceID(it->unique_id));
- if (!output_device_id.empty()) {
- VLOG(2) << it->unique_id << " matches with " << output_device_id;
- found_an_associated_device = true;
- }
- }
-
- EXPECT_TRUE(found_an_associated_device);
-#endif // defined(OS_WIN) || defined(OS_MACOSX)
-}
-
-} // namespace media
« no previous file with comments | « media/audio/audio_manager_base.cc ('k') | media/audio/cras/audio_manager_cras.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698