Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5718)

Unified Diff: chrome/test/chromedriver/commands_unittest.cc

Issue 23467010: [chromedriver] Logging tweaks and fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/commands.cc ('k') | chrome/test/chromedriver/logging.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/commands_unittest.cc
diff --git a/chrome/test/chromedriver/commands_unittest.cc b/chrome/test/chromedriver/commands_unittest.cc
index e377d2921813e96984c66dfdb749a429170379e8..44571863054bbd1a38e1ca25808019295033843a 100644
--- a/chrome/test/chromedriver/commands_unittest.cc
+++ b/chrome/test/chromedriver/commands_unittest.cc
@@ -138,6 +138,7 @@ TEST(CommandsTest, ExecuteSessionCommand) {
base::RunLoop run_loop;
ExecuteSessionCommand(
&map,
+ "cmd",
cmd,
false,
params,
@@ -176,6 +177,7 @@ TEST(CommandsTest, ExecuteSessionCommandOnNoSuchSession) {
SessionThreadMap map;
base::DictionaryValue params;
ExecuteSessionCommand(&map,
+ "cmd",
base::Bind(&ShouldNotBeCalled),
false,
params,
@@ -187,6 +189,7 @@ TEST(CommandsTest, ExecuteSessionCommandOnNoSuchSessionWhenItExpectsOk) {
SessionThreadMap map;
base::DictionaryValue params;
ExecuteSessionCommand(&map,
+ "cmd",
base::Bind(&ShouldNotBeCalled),
true,
params,
@@ -217,6 +220,7 @@ TEST(CommandsTest, ExecuteSessionCommandOnJustDeletedSession) {
base::MessageLoop loop;
base::RunLoop run_loop;
ExecuteSessionCommand(&map,
+ "cmd",
base::Bind(&ShouldNotBeCalled),
false,
base::DictionaryValue(),
« no previous file with comments | « chrome/test/chromedriver/commands.cc ('k') | chrome/test/chromedriver/logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698