Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4042)

Unified Diff: chrome/test/chromedriver/logging.h

Issue 23467010: [chromedriver] Logging tweaks and fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/logging.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/logging.h
diff --git a/chrome/test/chromedriver/logging.h b/chrome/test/chromedriver/logging.h
index bfea30c41fa2343dc75250f48aba873bd2000963..04beed8c922ca96f00b5f7538e3ae97e45dcadf9 100644
--- a/chrome/test/chromedriver/logging.h
+++ b/chrome/test/chromedriver/logging.h
@@ -22,6 +22,10 @@ class Status;
// See https://code.google.com/p/selenium/wiki/Logging.
class WebDriverLog : public Log {
public:
+ static const char kBrowserType[];
+ static const char kDriverType[];
+ static const char kPerformanceType[];
+
// Converts WD wire protocol level name -> Level, false on bad name.
static bool NameToLevel(const std::string& name, Level* out_level);
@@ -41,11 +45,12 @@ class WebDriverLog : public Log {
const std::string& message) OVERRIDE;
const std::string& type() const;
+ void set_min_level(Level min_level);
Level min_level() const;
private:
const std::string type_; // WebDriver log type.
- const Level min_level_; // Minimum level of entries to store.
+ Level min_level_; // Minimum level of entries to store.
scoped_ptr<base::ListValue> entries_; // Accumulated entries.
DISALLOW_COPY_AND_ASSIGN(WebDriverLog);
@@ -57,7 +62,6 @@ bool InitLogging();
// Creates Log's and DevToolsEventListener's based on logging preferences.
Status CreateLogs(const Capabilities& capabilities,
ScopedVector<WebDriverLog>* out_logs,
- scoped_ptr<WebDriverLog>* out_driver_log,
ScopedVector<DevToolsEventListener>* out_listeners);
#endif // CHROME_TEST_CHROMEDRIVER_LOGGING_H_
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/logging.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698