Issue 23466012: Pepper: Remove wrong fs operationrunner shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23466012: Pepper: Remove wrong fs operationrunner shutdown. (Closed)

Created:
7 years, 3 months ago by teravest

Modified:
7 years, 3 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Remove wrong fs operationrunner shutdown. Today, PepperFileSystemBrowserHost errnoeously calls Shutdown() on the FileSystemOperationRunner used by the FileSystemContext it gets. This is incorrect; other code in Chrome (or another PepperFileSystemBrowserHost) could be using the same FileSystemOperationRunner, and its operations will be cancelled. BUG=225441 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221861

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/23466012/1

7 years, 3 months ago (2013-09-06 23:36:28 UTC) #3

Message was sent while issue was closed.

Change committed as 221861

Expand Messages | Collapse Messages