Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc

Issue 23466012: Pepper: Remove wrong fs operationrunner shutdown. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/pepper/pepper_file_system_browser_host.h " 5 #include "content/browser/renderer_host/pepper/pepper_file_system_browser_host.h "
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "content/public/browser/browser_ppapi_host.h" 9 #include "content/public/browser/browser_ppapi_host.h"
10 #include "content/public/browser/browser_thread.h" 10 #include "content/public/browser/browser_thread.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 : ResourceHost(host->GetPpapiHost(), instance, resource), 59 : ResourceHost(host->GetPpapiHost(), instance, resource),
60 browser_ppapi_host_(host), 60 browser_ppapi_host_(host),
61 type_(type), 61 type_(type),
62 opened_(false), 62 opened_(false),
63 fs_context_(NULL), 63 fs_context_(NULL),
64 called_open_(false), 64 called_open_(false),
65 weak_factory_(this) { 65 weak_factory_(this) {
66 } 66 }
67 67
68 PepperFileSystemBrowserHost::~PepperFileSystemBrowserHost() { 68 PepperFileSystemBrowserHost::~PepperFileSystemBrowserHost() {
69 if (fs_context_.get()) 69 // TODO(teravest): Create a FileSystemOperationRunner
70 fs_context_->operation_runner()->Shutdown(); 70 // per-PepperFileSystemBrowserHost, force users of this FileSystem to use it,
71 // and call Shutdown() on it here.
71 } 72 }
72 73
73 int32_t PepperFileSystemBrowserHost::OnResourceMessageReceived( 74 int32_t PepperFileSystemBrowserHost::OnResourceMessageReceived(
74 const IPC::Message& msg, 75 const IPC::Message& msg,
75 ppapi::host::HostMessageContext* context) { 76 ppapi::host::HostMessageContext* context) {
76 IPC_BEGIN_MESSAGE_MAP(PepperFileSystemBrowserHost, msg) 77 IPC_BEGIN_MESSAGE_MAP(PepperFileSystemBrowserHost, msg)
77 PPAPI_DISPATCH_HOST_RESOURCE_CALL( 78 PPAPI_DISPATCH_HOST_RESOURCE_CALL(
78 PpapiHostMsg_FileSystem_Open, 79 PpapiHostMsg_FileSystem_Open,
79 OnHostMsgOpen) 80 OnHostMsgOpen)
80 PPAPI_DISPATCH_HOST_RESOURCE_CALL( 81 PPAPI_DISPATCH_HOST_RESOURCE_CALL(
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 BrowserThread::UI, 202 BrowserThread::UI,
202 FROM_HERE, 203 FROM_HERE,
203 base::Bind(&GetFileSystemContextFromRenderId, render_process_id), 204 base::Bind(&GetFileSystemContextFromRenderId, render_process_id),
204 base::Bind(&PepperFileSystemBrowserHost::GotIsolatedFileSystemContext, 205 base::Bind(&PepperFileSystemBrowserHost::GotIsolatedFileSystemContext,
205 weak_factory_.GetWeakPtr(), 206 weak_factory_.GetWeakPtr(),
206 context->MakeReplyMessageContext())); 207 context->MakeReplyMessageContext()));
207 return PP_OK_COMPLETIONPENDING; 208 return PP_OK_COMPLETIONPENDING;
208 } 209 }
209 210
210 } // namespace content 211 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698