Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8449)

Unified Diff: Source/wtf/text/StringImpl.h

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/wtf/Vector.h ('k') | Source/wtf/text/StringImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/wtf/text/StringImpl.h
diff --git a/Source/wtf/text/StringImpl.h b/Source/wtf/text/StringImpl.h
index 02acb974ca2a7a141f5859da7f619200146c9489..68d3ec7d9d2a51a599e2647793ce63251de170a1 100644
--- a/Source/wtf/text/StringImpl.h
+++ b/Source/wtf/text/StringImpl.h
@@ -507,7 +507,7 @@ inline size_t find(const CharacterType* characters, unsigned length, CharacterTy
return index;
++index;
}
- return notFound;
+ return kNotFound;
}
ALWAYS_INLINE size_t find(const UChar* characters, unsigned length, LChar matchCharacter, unsigned index = 0)
@@ -518,7 +518,7 @@ ALWAYS_INLINE size_t find(const UChar* characters, unsigned length, LChar matchC
inline size_t find(const LChar* characters, unsigned length, UChar matchCharacter, unsigned index = 0)
{
if (matchCharacter & ~0xFF)
- return notFound;
+ return kNotFound;
return find(characters, length, static_cast<LChar>(matchCharacter), index);
}
@@ -529,7 +529,7 @@ inline size_t find(const LChar* characters, unsigned length, CharacterMatchFunct
return index;
++index;
}
- return notFound;
+ return kNotFound;
}
inline size_t find(const UChar* characters, unsigned length, CharacterMatchFunctionPtr matchFunction, unsigned index = 0)
@@ -539,7 +539,7 @@ inline size_t find(const UChar* characters, unsigned length, CharacterMatchFunct
return index;
++index;
}
- return notFound;
+ return kNotFound;
}
template<typename CharacterType>
@@ -570,20 +570,20 @@ inline size_t findNextLineStart(const CharacterType* characters, unsigned length
return index;
}
}
- return notFound;
+ return kNotFound;
}
template<typename CharacterType>
inline size_t reverseFindLineTerminator(const CharacterType* characters, unsigned length, unsigned index = UINT_MAX)
{
if (!length)
- return notFound;
+ return kNotFound;
if (index >= length)
index = length - 1;
CharacterType c = characters[index];
while ((c != '\n') && (c != '\r')) {
if (!index--)
- return notFound;
+ return kNotFound;
c = characters[index];
}
return index;
@@ -593,12 +593,12 @@ template<typename CharacterType>
inline size_t reverseFind(const CharacterType* characters, unsigned length, CharacterType matchCharacter, unsigned index = UINT_MAX)
{
if (!length)
- return notFound;
+ return kNotFound;
if (index >= length)
index = length - 1;
while (characters[index] != matchCharacter) {
if (!index--)
- return notFound;
+ return kNotFound;
}
return index;
}
@@ -611,7 +611,7 @@ ALWAYS_INLINE size_t reverseFind(const UChar* characters, unsigned length, LChar
inline size_t reverseFind(const LChar* characters, unsigned length, UChar matchCharacter, unsigned index = UINT_MAX)
{
if (matchCharacter & ~0xFF)
- return notFound;
+ return kNotFound;
return reverseFind(characters, length, static_cast<LChar>(matchCharacter), index);
}
« no previous file with comments | « Source/wtf/Vector.h ('k') | Source/wtf/text/StringImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698