Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: Source/core/xml/XPathFunctions.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/tests/ArenaTestHelpers.h ('k') | Source/core/xml/XPathParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/XPathFunctions.cpp
diff --git a/Source/core/xml/XPathFunctions.cpp b/Source/core/xml/XPathFunctions.cpp
index 94ddadda8838143f9ae8758e3619df71032c7985..55004df0f1226b59b432661ade9bf7c8f873eb5f 100644
--- a/Source/core/xml/XPathFunctions.cpp
+++ b/Source/core/xml/XPathFunctions.cpp
@@ -478,7 +478,7 @@ Value FunSubstringBefore::evaluate() const
size_t i = s1.find(s2);
- if (i == notFound)
+ if (i == kNotFound)
return "";
return s1.left(i);
@@ -490,7 +490,7 @@ Value FunSubstringAfter::evaluate() const
String s2 = arg(1)->evaluate().toString();
size_t i = s1.find(s2);
- if (i == notFound)
+ if (i == kNotFound)
return "";
return s1.substring(i + s2.length());
@@ -556,7 +556,7 @@ Value FunTranslate::evaluate() const
UChar ch = s1[i1];
size_t i2 = s2.find(ch);
- if (i2 == notFound)
+ if (i2 == kNotFound)
result.append(ch);
else if (i2 < s3.length())
result.append(s3[i2]);
@@ -607,7 +607,7 @@ Value FunLang::evaluate() const
// Remove suffixes one by one.
size_t index = langValue.reverseFind('-');
- if (index == notFound)
+ if (index == kNotFound)
break;
langValue = langValue.left(index);
}
« no previous file with comments | « Source/core/tests/ArenaTestHelpers.h ('k') | Source/core/xml/XPathParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698