Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: Source/core/platform/text/win/LocaleWin.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/platform/text/mac/LocaleMac.mm ('k') | Source/core/rendering/RenderGeometryMap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/platform/text/win/LocaleWin.cpp
diff --git a/Source/core/platform/text/win/LocaleWin.cpp b/Source/core/platform/text/win/LocaleWin.cpp
index e29b5af73c6b839d0c5c1f424eb62a7657e28185..811fd6d82a2c66b27af3be070ff7ebc84aa01c21 100644
--- a/Source/core/platform/text/win/LocaleWin.cpp
+++ b/Source/core/platform/text/win/LocaleWin.cpp
@@ -57,7 +57,7 @@ typedef HashMap<String, LCID> NameToLCIDMap;
static String extractLanguageCode(const String& locale)
{
size_t dashPosition = locale.find('-');
- if (dashPosition == notFound)
+ if (dashPosition == kNotFound)
return locale;
return locale.left(dashPosition);
}
@@ -65,7 +65,7 @@ static String extractLanguageCode(const String& locale)
static String removeLastComponent(const String& name)
{
size_t lastSeparator = name.reverseFind('-');
- if (lastSeparator == notFound)
+ if (lastSeparator == kNotFound)
return emptyString();
return name.left(lastSeparator);
}
@@ -455,7 +455,7 @@ String LocaleWin::shortTimeFormat()
builder.append(getLocaleInfoString(LOCALE_STIME));
builder.append("ss");
size_t pos = format.reverseFind(builder.toString());
- if (pos != notFound)
+ if (pos != kNotFound)
format.remove(pos, builder.length());
}
m_timeFormatWithoutSeconds = convertWindowsDateTimeFormat(format);
« no previous file with comments | « Source/core/platform/text/mac/LocaleMac.mm ('k') | Source/core/rendering/RenderGeometryMap.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698