Source/core/platform/text/LocaleToScriptMappingDefault.cpp - Issue 23464095: WTF::notFound looks too much like a local variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/text/LocaleToScriptMappingDefault.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/platform/text/LocaleToScriptMappingDefault.cpp

diff --git a/Source/core/platform/text/LocaleToScriptMappingDefault.cpp b/Source/core/platform/text/LocaleToScriptMappingDefault.cpp

index 6a410f3a5e8fa6e3e7f45529c80d7dadf0d8551b..197d87a99668a5cf878235c43a9189300ea3aa50 100644

--- a/Source/core/platform/text/LocaleToScriptMappingDefault.cpp

+++ b/Source/core/platform/text/LocaleToScriptMappingDefault.cpp

@@ -391,7 +391,7 @@ UScriptCode localeToScriptCodeForFontSelection(const String& locale)

if (it != localeScriptMap.end())

return it->value;

size_t pos = canonicalLocale.reverseFind('_');

- if (pos == notFound)

+ if (pos == kNotFound)

break;

UScriptCode code = scriptNameToCode(canonicalLocale.substring(pos + 1));

if (code != USCRIPT_INVALID_CODE && code != USCRIPT_UNKNOWN)