Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: Source/core/platform/image-decoders/gif/GIFImageDecoder.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/platform/image-decoders/gif/GIFImageDecoder.cpp
diff --git a/Source/core/platform/image-decoders/gif/GIFImageDecoder.cpp b/Source/core/platform/image-decoders/gif/GIFImageDecoder.cpp
index 21ef4d130a4db82d8b99fa7c0086f10a25dd69e6..783a3d72367533f183664fded44e2ba38c06a436 100644
--- a/Source/core/platform/image-decoders/gif/GIFImageDecoder.cpp
+++ b/Source/core/platform/image-decoders/gif/GIFImageDecoder.cpp
@@ -228,8 +228,8 @@ bool GIFImageDecoder::frameComplete(size_t frameIndex)
// resulting buffer was non-transparent, and we can setHasAlpha(false).
if (buffer.originalFrameRect().contains(IntRect(IntPoint(), size()))) {
buffer.setHasAlpha(false);
- buffer.setRequiredPreviousFrameIndex(notFound);
- } else if (buffer.requiredPreviousFrameIndex() != notFound) {
+ buffer.setRequiredPreviousFrameIndex(kNotFound);
+ } else if (buffer.requiredPreviousFrameIndex() != kNotFound) {
// Tricky case. This frame does not have alpha only if everywhere
// outside its rect doesn't have alpha. To know whether this is
// true, we check the start state of the frame -- if it doesn't have
@@ -327,7 +327,7 @@ void GIFImageDecoder::decode(size_t frameIndex)
do {
framesToDecode.append(frameToDecode);
frameToDecode = m_frameBufferCache[frameToDecode].requiredPreviousFrameIndex();
- } while (frameToDecode != notFound && m_frameBufferCache[frameToDecode].status() != ImageFrame::FrameComplete);
+ } while (frameToDecode != kNotFound && m_frameBufferCache[frameToDecode].status() != ImageFrame::FrameComplete);
for (size_t i = framesToDecode.size(); i > 0; --i) {
size_t frameIndex = framesToDecode[i - 1];
@@ -354,7 +354,7 @@ bool GIFImageDecoder::initFrameBuffer(size_t frameIndex)
ImageFrame* const buffer = &m_frameBufferCache[frameIndex];
size_t requiredPreviousFrameIndex = buffer->requiredPreviousFrameIndex();
- if (requiredPreviousFrameIndex == notFound) {
+ if (requiredPreviousFrameIndex == kNotFound) {
// This frame doesn't rely on any previous data.
if (!buffer->setSize(size().width(), size().height()))
return setFailed();
« no previous file with comments | « Source/core/platform/image-decoders/ImageFrame.cpp ('k') | Source/core/platform/image-decoders/gif/GIFImageDecoderTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698