Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: Source/core/page/WindowFeatures.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/UserContentURLPattern.cpp ('k') | Source/core/platform/ContentType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/WindowFeatures.cpp
diff --git a/Source/core/page/WindowFeatures.cpp b/Source/core/page/WindowFeatures.cpp
index 1d944e6301a888a596d6213bb79abbbbd04bcdc8..8614ea0d6fa9acc642245721b95955fca8af6c4a 100644
--- a/Source/core/page/WindowFeatures.cpp
+++ b/Source/core/page/WindowFeatures.cpp
@@ -244,16 +244,16 @@ void WindowFeatures::parseDialogFeatures(const String& string, DialogFeaturesMap
size_t separatorPosition = featureString.find('=');
size_t colonPosition = featureString.find(':');
- if (separatorPosition != notFound && colonPosition != notFound)
+ if (separatorPosition != kNotFound && colonPosition != kNotFound)
continue; // ignore strings that have both = and :
- if (separatorPosition == notFound)
+ if (separatorPosition == kNotFound)
separatorPosition = colonPosition;
String key = featureString.left(separatorPosition).stripWhiteSpace().lower();
// Null string for value indicates key without value.
String value;
- if (separatorPosition != notFound) {
+ if (separatorPosition != kNotFound) {
value = featureString.substring(separatorPosition + 1).stripWhiteSpace().lower();
value = value.left(value.find(' '));
}
« no previous file with comments | « Source/core/page/UserContentURLPattern.cpp ('k') | Source/core/platform/ContentType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698