Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/DOMPatchSupport.cpp ('k') | Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDOMAgent.cpp
diff --git a/Source/core/inspector/InspectorDOMAgent.cpp b/Source/core/inspector/InspectorDOMAgent.cpp
index 7426d72a23da230a21dede10f89d1e7a20aaf7a4..1270a5e92e0499fe3008d4d1ce8bce611398ffe6 100644
--- a/Source/core/inspector/InspectorDOMAgent.cpp
+++ b/Source/core/inspector/InspectorDOMAgent.cpp
@@ -960,12 +960,12 @@ void InspectorDOMAgent::performSearch(ErrorString*, const String& whitespaceTrim
case Node::COMMENT_NODE:
case Node::CDATA_SECTION_NODE: {
String text = node->nodeValue();
- if (text.findIgnoringCase(whitespaceTrimmedQuery) != notFound)
+ if (text.findIgnoringCase(whitespaceTrimmedQuery) != kNotFound)
resultCollector.add(node);
break;
}
case Node::ELEMENT_NODE: {
- if ((!startTagFound && !endTagFound && (node->nodeName().findIgnoringCase(tagNameQuery) != notFound))
+ if ((!startTagFound && !endTagFound && (node->nodeName().findIgnoringCase(tagNameQuery) != kNotFound))
|| (startTagFound && endTagFound && equalIgnoringCase(node->nodeName(), tagNameQuery))
|| (startTagFound && !endTagFound && node->nodeName().startsWith(tagNameQuery, false))
|| (!startTagFound && endTagFound && node->nodeName().endsWith(tagNameQuery, false))) {
@@ -981,12 +981,12 @@ void InspectorDOMAgent::performSearch(ErrorString*, const String& whitespaceTrim
for (unsigned i = 0; i < numAttrs; ++i) {
// Add attribute pair
const Attribute* attribute = element->attributeItem(i);
- if (attribute->localName().find(whitespaceTrimmedQuery) != notFound) {
+ if (attribute->localName().find(whitespaceTrimmedQuery) != kNotFound) {
resultCollector.add(node);
break;
}
size_t foundPosition = attribute->value().find(attributeQuery);
- if (foundPosition != notFound) {
+ if (foundPosition != kNotFound) {
if (!exactAttributeMatch || (!foundPosition && attribute->value().length() == attributeQuery.length())) {
resultCollector.add(node);
break;
« no previous file with comments | « Source/core/inspector/DOMPatchSupport.cpp ('k') | Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698