Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: Source/core/html/track/TextTrackCue.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/parser/XSSAuditor.cpp ('k') | Source/core/html/track/TextTrackCueList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/TextTrackCue.cpp
diff --git a/Source/core/html/track/TextTrackCue.cpp b/Source/core/html/track/TextTrackCue.cpp
index 167f03209d0f0dcf031bef1ba3174be2cc567f2c..b4ddc64c93dbd2f6bab16c6b7986af7245737da8 100644
--- a/Source/core/html/track/TextTrackCue.cpp
+++ b/Source/core/html/track/TextTrackCue.cpp
@@ -931,7 +931,7 @@ void TextTrackCue::setCueSettings(const String& input)
String setting = WebVTTParser::collectWord(input, &endOfSetting);
CueSetting name;
size_t colonOffset = setting.find(':', 1);
- if (colonOffset == notFound || colonOffset == 0 || colonOffset == setting.length() - 1)
+ if (colonOffset == kNotFound || !colonOffset || colonOffset == setting.length() - 1)
goto NextSetting;
// 2. Let name be the leading substring of setting up to and excluding the first U+003A COLON character (:) in that string.
@@ -978,7 +978,7 @@ void TextTrackCue::setCueSettings(const String& input)
// 4. If any character in value other than the last character is a U+0025 PERCENT SIGN character (%), then
// jump to the step labeled next setting.
String linePosition = linePositionBuilder.toString();
- if (linePosition.find('-', 1) != notFound || linePosition.reverseFind("%", linePosition.length() - 2) != notFound)
+ if (linePosition.find('-', 1) != kNotFound || linePosition.reverseFind("%", linePosition.length() - 2) != kNotFound)
break;
// 5. If the first character in value is a U+002D HYPHEN-MINUS character (-) and the last character in value is a
« no previous file with comments | « Source/core/html/parser/XSSAuditor.cpp ('k') | Source/core/html/track/TextTrackCueList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698