Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: Source/web/WebFrameImpl.cpp

Issue 23464095: WTF::notFound looks too much like a local variable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/PageOverlayList.cpp ('k') | Source/web/WebPageSerializer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1108 matching lines...) Expand 10 before | Expand all | Expand 10 after
1119 return false; 1119 return false;
1120 IntRect intRect = frame()->editor().firstRectForRange(range.get()); 1120 IntRect intRect = frame()->editor().firstRectForRange(range.get());
1121 rect = WebRect(intRect); 1121 rect = WebRect(intRect);
1122 rect = frame()->view()->contentsToWindow(rect); 1122 rect = frame()->view()->contentsToWindow(rect);
1123 return true; 1123 return true;
1124 } 1124 }
1125 1125
1126 size_t WebFrameImpl::characterIndexForPoint(const WebPoint& webPoint) const 1126 size_t WebFrameImpl::characterIndexForPoint(const WebPoint& webPoint) const
1127 { 1127 {
1128 if (!frame()) 1128 if (!frame())
1129 return notFound; 1129 return kNotFound;
1130 1130
1131 IntPoint point = frame()->view()->windowToContents(webPoint); 1131 IntPoint point = frame()->view()->windowToContents(webPoint);
1132 HitTestResult result = frame()->eventHandler()->hitTestResultAtPoint(point, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::DisallowShad owContent); 1132 HitTestResult result = frame()->eventHandler()->hitTestResultAtPoint(point, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::DisallowShad owContent);
1133 RefPtr<Range> range = frame()->rangeForPoint(result.roundedPointInInnerNodeF rame()); 1133 RefPtr<Range> range = frame()->rangeForPoint(result.roundedPointInInnerNodeF rame());
1134 if (!range) 1134 if (!range)
1135 return notFound; 1135 return kNotFound;
1136 1136
1137 size_t location, length; 1137 size_t location, length;
1138 TextIterator::getLocationAndLengthFromRange(frame()->selection().rootEditabl eElementOrDocumentElement(), range.get(), location, length); 1138 TextIterator::getLocationAndLengthFromRange(frame()->selection().rootEditabl eElementOrDocumentElement(), range.get(), location, length);
1139 return location; 1139 return location;
1140 } 1140 }
1141 1141
1142 bool WebFrameImpl::executeCommand(const WebString& name, const WebNode& node) 1142 bool WebFrameImpl::executeCommand(const WebString& name, const WebNode& node)
1143 { 1143 {
1144 ASSERT(frame()); 1144 ASSERT(frame());
1145 1145
(...skipping 1330 matching lines...) Expand 10 before | Expand all | Expand 10 after
2476 2476
2477 // There is a possibility that the frame being detached was the only 2477 // There is a possibility that the frame being detached was the only
2478 // pending one. We need to make sure final replies can be sent. 2478 // pending one. We need to make sure final replies can be sent.
2479 flushCurrentScopingEffort(m_findRequestIdentifier); 2479 flushCurrentScopingEffort(m_findRequestIdentifier);
2480 2480
2481 cancelPendingScopingEffort(); 2481 cancelPendingScopingEffort();
2482 } 2482 }
2483 } 2483 }
2484 2484
2485 } // namespace WebKit 2485 } // namespace WebKit
OLDNEW
« no previous file with comments | « Source/web/PageOverlayList.cpp ('k') | Source/web/WebPageSerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698