Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23464036: Adds a comment to GridLayout to explain what DCHECK does (Closed)

Created:
7 years, 3 months ago by sky
Modified:
7 years, 3 months ago
Reviewers:
Finnur
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Adds a comment to GridLayout to explain what DCHECK does BUG=none TEST=none R=finnur@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/views/layout/grid_layout.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
7 years, 3 months ago (2013-09-06 20:50:19 UTC) #1
Finnur
LGTM! This DCHECK had me puzzled for quite a while last week. Thank you.
7 years, 3 months ago (2013-09-08 20:11:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/23464036/1
7 years, 3 months ago (2013-09-09 14:59:34 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 17:55:59 UTC) #4
Message was sent while issue was closed. 
Change committed as 222055

Powered by Google App Engine
This is Rietveld 408576698