Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: ui/views/layout/grid_layout.cc

Issue 23464036: Adds a comment to GridLayout to explain what DCHECK does (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/layout/grid_layout.cc
diff --git a/ui/views/layout/grid_layout.cc b/ui/views/layout/grid_layout.cc
index 2927b88da9d5536e3d2195b58d6bcd9a5bca51af..0e4d4150020a17487f7978a0a633ace5d91a74db 100644
--- a/ui/views/layout/grid_layout.cc
+++ b/ui/views/layout/grid_layout.cc
@@ -995,6 +995,9 @@ void GridLayout::AddViewState(ViewState* view_state) {
void GridLayout::AddRow(Row* row) {
current_row_++;
remaining_row_span_--;
+ // GridLayout requires that if you add a View with a row span you use the same
+ // column set for each of the rows the view lands it. This DCHECK verifies
+ // that.
DCHECK(remaining_row_span_ <= 0 ||
row->column_set() == NULL ||
row->column_set() == GetLastValidColumnSet());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698