Issue 23463036: Positioning should account for the grid items' margins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23463036: Positioning should account for the grid items' margins (Closed)

Created:
7 years, 3 months ago by Julien - ping for review

Modified:
7 years, 3 months ago

Reviewers:
esprehn, eseidel

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, ojan, eseidel

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Positioning should account for the grid items' margins This change just adds the margin before / start to the grid items' positions. In order to get consistent behavior, we now have to call findChildLogicalPosition after layout (that's where we compute the margins). Also removed some FIXMEs that were handled in the code. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157925

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -8 lines)			Patch
M	LayoutTests/fast/css-grid-layout/grid-item-display.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	LayoutTests/fast/css-grid-layout/grid-item-margin-resolution.html	View	1 chunk	+97 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css-grid-layout/grid-item-margin-resolution-expected.txt	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderGrid.cpp	View	3 chunks	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/23463036/1

7 years, 3 months ago (2013-09-17 22:28:44 UTC) #3

Message was sent while issue was closed.

Change committed as 157925

Expand Messages | Collapse Messages