Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 23463012: Make the mousemove event cancellable (Closed)

Created:
7 years, 3 months ago by Daniel Bratell
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make the mousemove event cancellable The mouse move event used to be non cancellable in the 90s and when the specications changes in 2002-2003, not not everyone noticed. Specification: http://www.w3.org/TR/DOM-Level-3-Events/#event-type-mousemove Already implemented by MSIE and Opera (Presto). Still an open (and forgotten?) bug in Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=704423 BUG=261449 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
A LayoutTests/fast/events/mousemove.html View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/mousemove-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/dom/MouseEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Daniel Bratell
abarth, can you take a look please? It's a small fix (and, sorry to say, ...
7 years, 3 months ago (2013-09-02 09:28:52 UTC) #1
abarth-chromium
This seems fine. Can you add a link to the specification and a description of ...
7 years, 3 months ago (2013-09-03 15:59:55 UTC) #2
Daniel Bratell
On 2013/09/03 15:59:55, abarth wrote: > This seems fine. Can you add a link to ...
7 years, 3 months ago (2013-09-03 18:31:40 UTC) #3
abarth-chromium
On 2013/09/03 18:31:40, Daniel Bratell wrote: > Should I add something like this to the ...
7 years, 3 months ago (2013-09-03 21:08:12 UTC) #4
abarth-chromium
LGTM w/ updated description
7 years, 3 months ago (2013-09-03 21:08:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/23463012/1
7 years, 3 months ago (2013-09-04 06:08:57 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 08:11:11 UTC) #7
Message was sent while issue was closed.
Change committed as 157207

Powered by Google App Engine
This is Rietveld 408576698