Source/core/dom/MouseEvent.cpp - Issue 23463012: Make the mousemove event cancellable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/MouseEvent.cpp

Issue 23463012: Make the mousemove event cancellable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/MouseEvent.cpp

diff --git a/Source/core/dom/MouseEvent.cpp b/Source/core/dom/MouseEvent.cpp

index 2d5f32822f03fb1a0fbcbd945c25684243572758..13bd886a31efd7abbbb69efac470b3455d6668ae 100644

--- a/Source/core/dom/MouseEvent.cpp

+++ b/Source/core/dom/MouseEvent.cpp

@@ -58,7 +58,7 @@ PassRefPtr<MouseEvent> MouseEvent::create(const AtomicString& eventType, PassRef

ASSERT(event.type() == PlatformEvent::MouseMoved || event.button() != NoButton);

bool isMouseEnterOrLeave = eventType == eventNames().mouseenterEvent || eventType == eventNames().mouseleaveEvent;

- bool isCancelable = eventType != eventNames().mousemoveEvent && !isMouseEnterOrLeave;

+ bool isCancelable = !isMouseEnterOrLeave;

bool isBubbling = !isMouseEnterOrLeave;

return MouseEvent::create(eventType, isBubbling, isCancelable, view,

« no previous file with comments | « LayoutTests/fast/events/mousemove-expected.txt ('k') | no next file » | no next file with comments »