Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23460003: Merge IBusContorllerBase into IBusControllerImpl. (Closed)

Created:
7 years, 3 months ago by Hiro Komatsu
Modified:
7 years, 3 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, yusukes+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Merge IBusContorllerBase into IBusControllerImpl. BUG=279050 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220508

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a line break per code review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -168 lines) Patch
D chrome/browser/chromeos/input_method/ibus_controller_base.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/chromeos/input_method/ibus_controller_base.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/chromeos/input_method/ibus_controller_base_unittest.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.h View 3 chunks +18 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc View 1 2 chunks +56 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Hiro Komatsu
This CL completes the deletion of IBusControllerBase as tracked on crbug/279050.
7 years, 3 months ago (2013-08-27 05:01:28 UTC) #1
Seigo Nonaka
lgtm Thank you for your cleaning up! https://codereview.chromium.org/23460003/diff/1/chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc File chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc (right): https://codereview.chromium.org/23460003/diff/1/chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc#newcode27 chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc:27: virtual ~TestIBusController() ...
7 years, 3 months ago (2013-08-27 11:31:12 UTC) #2
Hiro Komatsu
https://codereview.chromium.org/23460003/diff/1/chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc File chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc (right): https://codereview.chromium.org/23460003/diff/1/chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc#newcode27 chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc:27: virtual ~TestIBusController() { On 2013/08/27 11:31:12, Seigo Nonaka wrote: ...
7 years, 3 months ago (2013-08-28 01:41:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/23460003/6001
7 years, 3 months ago (2013-08-29 01:54:44 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, ...
7 years, 3 months ago (2013-08-29 07:14:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/23460003/6001
7 years, 3 months ago (2013-08-30 04:38:32 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 05:36:20 UTC) #7
Message was sent while issue was closed. 
Change committed as 220508

Powered by Google App Engine
This is Rietveld 408576698