Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2974)

Unified Diff: chrome/browser/chromeos/input_method/ibus_controller_base.h

Issue 23460003: Merge IBusContorllerBase into IBusControllerImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a line break per code review. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/ibus_controller_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/input_method/ibus_controller_base.h
diff --git a/chrome/browser/chromeos/input_method/ibus_controller_base.h b/chrome/browser/chromeos/input_method/ibus_controller_base.h
deleted file mode 100644
index 3e238e24b23326c5f9cb68cb819f04d839977f3f..0000000000000000000000000000000000000000
--- a/chrome/browser/chromeos/input_method/ibus_controller_base.h
+++ /dev/null
@@ -1,44 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_CHROMEOS_INPUT_METHOD_IBUS_CONTROLLER_BASE_H_
-#define CHROME_BROWSER_CHROMEOS_INPUT_METHOD_IBUS_CONTROLLER_BASE_H_
-
-#include <utility>
-
-#include "base/observer_list.h"
-#include "chrome/browser/chromeos/input_method/ibus_controller.h"
-#include "chromeos/ime/input_method_property.h"
-
-namespace chromeos {
-namespace input_method {
-
-// The common implementation of the IBusController. This file does not depend on
-// libibus, hence is unit-testable.
-class IBusControllerBase : public IBusController {
- public:
- IBusControllerBase();
- virtual ~IBusControllerBase();
-
- // IBusController overrides. Derived classes should not override these 4
- // functions.
- virtual void AddObserver(Observer* observer) OVERRIDE;
- virtual void RemoveObserver(Observer* observer) OVERRIDE;
- virtual const InputMethodPropertyList& GetCurrentProperties() const OVERRIDE;
- virtual void ClearProperties() OVERRIDE;
-
- protected:
- ObserverList<Observer> observers_;
-
- // The value which will be returned by GetCurrentProperties(). Derived classes
- // should update this variable when needed.
- InputMethodPropertyList current_property_list_;
-
- DISALLOW_COPY_AND_ASSIGN(IBusControllerBase);
-};
-
-} // namespace input_method
-} // namespace chromeos
-
-#endif // CHROME_BROWSER_CHROMEOS_INPUT_METHOD_IBUS_CONTROLLER_BASE_H_
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/ibus_controller_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698