Fix feedback attach a file and system info code.

Fix feedback attach a file and system info code.
Attaching a file to feedback is crashing the app since we fail on the AttachedFile validate (since we don't actually send blobs over, the attachedFile.data field is always empty, which fails parameter validation on the Chrome side). The easiest way to fix it was to make the parameter optional, since we never read it anyway. It is only there to hold the data so that the feedback custom bindings can move it into attachedFileBlobUrl.

This CL also fixes the sys info, which wasn't being sent due to code that was ported over from the UI incorrectly. The new UI does not need to wait on system information collection, since that is now done via a separate call, making passing around the sys_info variable completely redundant, and in this case wrong.

R=asargent@chromium.org
BUG=285942, 285938
TEST=We are able to attach a file and system information with a feedback report.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221866

[asargent_no_longer_on_chrome, 2013-09-06 22:53:48]

lgtm

https://codereview.chromium.org/23458031/diff/1/chrome/browser/feedback/feedb...
File chrome/browser/feedback/feedback_data.cc (right):

https://codereview.chromium.org/23458031/diff/1/chrome/browser/feedback/feedb...
chrome/browser/feedback/feedback_data.cc:99: void FeedbackData::set_sys_info(
style nit: I think the style guide recommends that functions only have
all-lowercase names if they are very simple/cheap (eg just setting an instance
variable). This seems to be a bit more complicated than that. =) Would it make
sense to rename it with title case?

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Names

[rkc, 2013-09-06 23:02:16]

https://codereview.chromium.org/23458031/diff/1/chrome/browser/feedback/feedb...
File chrome/browser/feedback/feedback_data.cc (right):

https://codereview.chromium.org/23458031/diff/1/chrome/browser/feedback/feedb...
chrome/browser/feedback/feedback_data.cc:99: void FeedbackData::set_sys_info(
On 2013/09/06 22:53:48, Antony Sargent wrote:
> style nit: I think the style guide recommends that functions only have
> all-lowercase names if they are very simple/cheap (eg just setting an instance
> variable). This seems to be a bit more complicated than that. =) Would it make
> sense to rename it with title case?
> 
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Names
> 
> 
> 

Yeah, this is just legacy - used to do only one thing, now does a lot. Renaming
it makes sense. Also moved the functions in the .cc file around to match their
order in the .h

Done.

[commit-bot: I haz the power, 2013-09-06 23:17:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rkc@chromium.org/23458031/6001

[commit-bot: I haz the power, 2013-09-07 02:53:22]

Change committed as 221866