Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3291)

Unified Diff: chrome/browser/feedback/feedback_data.h

Issue 23458031: Fix feedback attach a file and system info code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/feedback/feedback_data.h
diff --git a/chrome/browser/feedback/feedback_data.h b/chrome/browser/feedback/feedback_data.h
index 9193dace55cee00c16ef5c1bd798d462bd16c749..0cf912d2ad17f3c458fbc7819374500c873132b7 100644
--- a/chrome/browser/feedback/feedback_data.h
+++ b/chrome/browser/feedback/feedback_data.h
@@ -27,15 +27,15 @@ class FeedbackData : public base::RefCountedThreadSafe<FeedbackData> {
FeedbackData();
- // Called once we've update all the data from the feedback page.
+ // Called once we've updated all the data from the feedback page.
void OnFeedbackPageDataComplete();
- // Called once we have read our system logs.
- void CompressSyslogs(scoped_ptr<SystemLogsMap> sys_info);
+ // Sets the system information for this instance and kicks off its
+ // compression.
+ void SetAndCompressSystemInfo(scoped_ptr<SystemLogsMap> sys_info);
- // Called once we have read and compressed our system logs.
- void OnCompressLogsComplete(scoped_ptr<SystemLogsMap> sys_info,
- scoped_ptr<std::string> compressed_logs);
+ // Called once we have compressed our system logs.
+ void OnCompressLogsComplete(scoped_ptr<std::string> compressed_logs);
// Returns true if we've completed all the tasks needed before we can send
// feedback - at this time this is includes getting the feedback page data
@@ -45,10 +45,6 @@ class FeedbackData : public base::RefCountedThreadSafe<FeedbackData> {
// Sends the feedback report if we have all our data complete.
void SendReport();
- // Starts reading the file to attach to this report into the string
- // file_data. ReadFileComplete is called once this is done.
- void StartReadFile(const std::string filename, const std::string* file_data);
-
// Getters
Profile* profile() const { return profile_; }
const std::string& category_tag() const { return category_tag_; }
@@ -84,7 +80,6 @@ class FeedbackData : public base::RefCountedThreadSafe<FeedbackData> {
}
void set_attached_file_url(const GURL& url) { attached_file_url_ = url; }
void set_screenshot_url(const GURL& url) { screenshot_url_ = url; }
- void set_sys_info(scoped_ptr<SystemLogsMap> sys_info);
private:
friend class base::RefCountedThreadSafe<FeedbackData>;
« no previous file with comments | « chrome/browser/extensions/api/feedback_private/feedback_private_api.cc ('k') | chrome/browser/feedback/feedback_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698