Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2345753002: Update WebRTC to build against libsrtp 2.0 (Closed)

Created:
4 years, 3 months ago by mattdr-at-webrtc.org
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update WebRTC to build against libsrtp 2.0 BUG=webrtc:6376 Committed: https://crrev.com/51f29197e67817f3d4d77a2d1b3018c06368a2cc Cr-Commit-Position: refs/heads/master@{#14424}

Patch Set 1 #

Patch Set 2 : Small rearrangement #

Patch Set 3 : Collapse srtp directory in relative includes #

Patch Set 4 : Remove conditional include #

Patch Set 5 : Respect HAVE_SRTP #

Patch Set 6 : y #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -70 lines) Patch
M webrtc/pc/externalhmac.h View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/pc/externalhmac.cc View 1 2 3 4 1 chunk +6 lines, -4 lines 0 comments Download
M webrtc/pc/srtpfilter.h View 1 2 chunks +7 lines, -3 lines 0 comments Download
M webrtc/pc/srtpfilter.cc View 1 2 3 4 5 13 chunks +37 lines, -36 lines 0 comments Download
M webrtc/pc/srtpfilter_unittest.cc View 1 2 4 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mattdr-at-webrtc.org
This compiles today thanks to https://codereview.chromium.org/2346813003. This also compiles against libsrtp2 from https://codereview.chromium.org/2344973002.
4 years, 2 months ago (2016-09-28 17:06:21 UTC) #3
kjellander_webrtc
Thanks for doing this! I'm not an owner here nor knows this code at all; ...
4 years, 2 months ago (2016-09-28 18:56:11 UTC) #5
Taylor Brandstetter
lgtm
4 years, 2 months ago (2016-09-28 19:27:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2345753002/120001
4 years, 2 months ago (2016-09-28 20:00:06 UTC) #8
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 2 months ago (2016-09-28 21:08:49 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 21:09:01 UTC) #12
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/51f29197e67817f3d4d77a2d1b3018c06368a2cc
Cr-Commit-Position: refs/heads/master@{#14424}

Powered by Google App Engine
This is Rietveld 408576698