Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 23454036: [Android WebView] Pass absolute URL to requestFocusNodeHref. (Closed)

Created:
7 years, 3 months ago by Primiano Tucci (use gerrit)
Modified:
7 years, 3 months ago
Reviewers:
joth, benm (inactive), boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android WebView] Pass absolute URL to requestFocusNodeHref. This CL changes the semantic of the |url| field of the requestFocusNodeHref method for compatility reasons, keeping consistent with the behavior of the old WebView. BUG=290905 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223298

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changed comment #

Total comments: 1

Patch Set 3 : Add bug ref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Primiano Tucci (use gerrit)
7 years, 3 months ago (2013-09-13 14:02:12 UTC) #1
boliu
lgtm if WebKitHitTestTest passes https://codereview.chromium.org/23454036/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (right): https://codereview.chromium.org/23454036/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java#newcode1296 android_webview/java/src/org/chromium/android_webview/AwContents.java:1296: data.putString("url", mPossiblyStaleHitTestData.hitTestResultExtraData); Ah hahaha, I ...
7 years, 3 months ago (2013-09-13 16:02:24 UTC) #2
joth
lgtm https://codereview.chromium.org/23454036/diff/7001/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (right): https://codereview.chromium.org/23454036/diff/7001/android_webview/java/src/org/chromium/android_webview/AwContents.java#newcode1292 android_webview/java/src/org/chromium/android_webview/AwContents.java:1292: // the absolute (full) url is passed in ...
7 years, 3 months ago (2013-09-13 20:24:14 UTC) #3
Primiano Tucci (use gerrit)
org.chromium.android_webview.test.WebKitHitTestTest: all test passed.
7 years, 3 months ago (2013-09-15 22:06:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/23454036/15001
7 years, 3 months ago (2013-09-15 22:40:52 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 02:44:51 UTC) #6
Message was sent while issue was closed.
Change committed as 223298

Powered by Google App Engine
This is Rietveld 408576698