Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 23454036: [Android WebView] Pass absolute URL to requestFocusNodeHref. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add bug ref Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index 631d5ed27b689f950284c2e324918e315c897b9b..81b36bd47ebcc6a25932f45c72ee96c375b27fee 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -1287,7 +1287,11 @@ public class AwContents {
nativeUpdateLastHitTestData(mNativeAwContents);
Bundle data = msg.getData();
- data.putString("url", mPossiblyStaleHitTestData.href);
+
+ // In order to maintain compatibility with the old WebView's implementation,
+ // the absolute (full) url is passed in the |url| field, not only the href attribute.
+ // Note: HitTestData could be cleaned up at this point. See http://crbug.com/290992.
+ data.putString("url", mPossiblyStaleHitTestData.hitTestResultExtraData);
data.putString("title", mPossiblyStaleHitTestData.anchorText);
data.putString("src", mPossiblyStaleHitTestData.imgSrc);
msg.setData(data);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698