Refactor PPB_NetworkMonitor_Private interface to use CompletionCallback.

Refactor PPB_NetworkMonitor_Private interface to use CompletionCallback.

Previously NetworkMonitor required that a callback is passed to the 
Create() method. It was hard to use and inconsistent with other APIs. 
Added new UpdateNetworkList() method which accepts a 
CompletionCallback to be called when network list changes.

BUG=281781
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221582

[yzshen1, 2013-09-04 19:52:01]

https://codereview.chromium.org/23453025/diff/7001/ppapi/api/private/ppb_netw...
File ppapi/api/private/ppb_network_monitor_private.idl (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/api/private/ppb_netw...
ppapi/api/private/ppb_network_monitor_private.idl:32: * Gets current network
configuration. When called for the first time, completes as
- longer than 80 chars

https://codereview.chromium.org/23453025/diff/7001/ppapi/cpp/private/network_...
File ppapi/cpp/private/network_monitor_private.cc (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/cpp/private/network_...
ppapi/cpp/private/network_monitor_private.cc:17: template <> const char*
interface_name<PPB_NetworkMonitor_Private>() {
nit: please consider appending the version number.

https://codereview.chromium.org/23453025/diff/7001/ppapi/cpp/private/network_...
File ppapi/cpp/private/network_monitor_private.h (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/cpp/private/network_...
ppapi/cpp/private/network_monitor_private.h:20: NetworkMonitorPrivate(const
InstanceHandle& instance);
explicit, please.

https://codereview.chromium.org/23453025/diff/7001/ppapi/proxy/ppb_network_mo...
File ppapi/proxy/ppb_network_monitor_private_proxy.cc (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/proxy/ppb_network_mo...
ppapi/proxy/ppb_network_monitor_private_proxy.cc:46:
thunk::EnterResourceCreation enter(pp_instance());
Please use EnterResourceCreationNoLock. At this point, the lock has been
acquired.

https://codereview.chromium.org/23453025/diff/7001/ppapi/proxy/ppb_network_mo...
ppapi/proxy/ppb_network_monitor_private_proxy.cc:78: OBJECT_IS_PROXY,
pp_instance(), list);
nit: please consider setting network_list_ to NULL.

https://codereview.chromium.org/23453025/diff/7001/ppapi/proxy/ppb_network_mo...
File ppapi/proxy/ppb_network_monitor_private_proxy.h (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/proxy/ppb_network_mo...
ppapi/proxy/ppb_network_monitor_private_proxy.h:49: // same thread that created
the NetworkMonitor.
This is no longer needed, because TrackedCallback will make sure that it is run
on the correct thread.

https://codereview.chromium.org/23453025/diff/7001/ppapi/tests/test_network_m...
File ppapi/tests/test_network_monitor_private.cc (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/tests/test_network_m...
ppapi/tests/test_network_monitor_private.cc:172: CallbackHandler
callback_handler(instance_->pp_instance());
Please consider using TestCompletionCallbackWithOutput.

https://codereview.chromium.org/23453025/diff/7001/ppapi/thunk/ppb_network_mo...
File ppapi/thunk/ppb_network_monitor_private_thunk.cc (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/thunk/ppb_network_mo...
ppapi/thunk/ppb_network_monitor_private_thunk.cc:18: PP_Resource
Create(PP_Instance instance) {
FYI: You could use [generate_thunk] in the idl file to auto gen this file and
save you some work.

[Sergey Ulanov, 2013-09-04 22:22:31]

https://codereview.chromium.org/23453025/diff/7001/ppapi/api/private/ppb_netw...
File ppapi/api/private/ppb_network_monitor_private.idl (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/api/private/ppb_netw...
ppapi/api/private/ppb_network_monitor_private.idl:32: * Gets current network
configuration. When called for the first time, completes as
On 2013/09/04 19:52:01, yzshen1 wrote:
> - longer than 80 chars

Done.

https://codereview.chromium.org/23453025/diff/7001/ppapi/cpp/private/network_...
File ppapi/cpp/private/network_monitor_private.cc (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/cpp/private/network_...
ppapi/cpp/private/network_monitor_private.cc:17: template <> const char*
interface_name<PPB_NetworkMonitor_Private>() {
On 2013/09/04 19:52:01, yzshen1 wrote:
> nit: please consider appending the version number.

Done.

https://codereview.chromium.org/23453025/diff/7001/ppapi/cpp/private/network_...
File ppapi/cpp/private/network_monitor_private.h (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/cpp/private/network_...
ppapi/cpp/private/network_monitor_private.h:20: NetworkMonitorPrivate(const
InstanceHandle& instance);
On 2013/09/04 19:52:01, yzshen1 wrote:
> explicit, please.

Done.

https://codereview.chromium.org/23453025/diff/7001/ppapi/proxy/ppb_network_mo...
File ppapi/proxy/ppb_network_monitor_private_proxy.cc (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/proxy/ppb_network_mo...
ppapi/proxy/ppb_network_monitor_private_proxy.cc:46:
thunk::EnterResourceCreation enter(pp_instance());
On 2013/09/04 19:52:01, yzshen1 wrote:
> Please use EnterResourceCreationNoLock. At this point, the lock has been
> acquired.

Done. Thanks for catching this.

https://codereview.chromium.org/23453025/diff/7001/ppapi/proxy/ppb_network_mo...
ppapi/proxy/ppb_network_monitor_private_proxy.cc:78: OBJECT_IS_PROXY,
pp_instance(), list);
On 2013/09/04 19:52:01, yzshen1 wrote:
> nit: please consider setting network_list_ to NULL.

Done.

https://codereview.chromium.org/23453025/diff/7001/ppapi/proxy/ppb_network_mo...
File ppapi/proxy/ppb_network_monitor_private_proxy.h (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/proxy/ppb_network_mo...
ppapi/proxy/ppb_network_monitor_private_proxy.h:49: // same thread that created
the NetworkMonitor.
On 2013/09/04 19:52:01, yzshen1 wrote:
> This is no longer needed, because TrackedCallback will make sure that it is
run
> on the correct thread.

Done.

https://codereview.chromium.org/23453025/diff/7001/ppapi/tests/test_network_m...
File ppapi/tests/test_network_monitor_private.cc (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/tests/test_network_m...
ppapi/tests/test_network_monitor_private.cc:172: CallbackHandler
callback_handler(instance_->pp_instance());
On 2013/09/04 19:52:01, yzshen1 wrote:
> Please consider using TestCompletionCallbackWithOutput.

Done.

https://codereview.chromium.org/23453025/diff/7001/ppapi/thunk/ppb_network_mo...
File ppapi/thunk/ppb_network_monitor_private_thunk.cc (right):

https://codereview.chromium.org/23453025/diff/7001/ppapi/thunk/ppb_network_mo...
ppapi/thunk/ppb_network_monitor_private_thunk.cc:18: PP_Resource
Create(PP_Instance instance) {
On 2013/09/04 19:52:01, yzshen1 wrote:
> FYI: You could use [generate_thunk] in the idl file to auto gen this file and
> save you some work.

Done.

[yzshen1, 2013-09-05 18:45:19]

LGTM

Thanks!

https://codereview.chromium.org/23453025/diff/21001/ppapi/thunk/ppb_network_m...
File ppapi/thunk/ppb_network_monitor_api.h (right):

https://codereview.chromium.org/23453025/diff/21001/ppapi/thunk/ppb_network_m...
ppapi/thunk/ppb_network_monitor_api.h:22: PP_Resource* network_list,
wrong indent.

[Sergey Ulanov, 2013-09-05 18:56:52]

https://codereview.chromium.org/23453025/diff/21001/ppapi/thunk/ppb_network_m...
File ppapi/thunk/ppb_network_monitor_api.h (right):

https://codereview.chromium.org/23453025/diff/21001/ppapi/thunk/ppb_network_m...
ppapi/thunk/ppb_network_monitor_api.h:22: PP_Resource* network_list,
On 2013/09/05 18:45:20, yzshen1 wrote:
> wrong indent.

Done.

[commit-bot: I haz the power, 2013-09-05 18:58:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/23453025/55001

[commit-bot: I haz the power, 2013-09-06 05:30:29]

Change committed as 221582