Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: remoting/client/plugin/pepper_network_manager.cc

Issue 23453025: Refactor PPB_NetworkMonitor_Private interface to use CompletionCallback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/plugin/pepper_network_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/plugin/pepper_network_manager.cc
diff --git a/remoting/client/plugin/pepper_network_manager.cc b/remoting/client/plugin/pepper_network_manager.cc
index d4fa68f5dd1d166ed0f71a2b7b67b38d709963c3..7b0f50f5764be88eb03b1dc2fe9ed76140139e83 100644
--- a/remoting/client/plugin/pepper_network_manager.cc
+++ b/remoting/client/plugin/pepper_network_manager.cc
@@ -17,11 +17,15 @@
namespace remoting {
PepperNetworkManager::PepperNetworkManager(const pp::InstanceHandle& instance)
- : monitor_(instance, &PepperNetworkManager::OnNetworkListCallbackHandler,
- this),
+ : monitor_(instance),
start_count_(0),
network_list_received_(false),
+ callback_factory_(this),
weak_factory_(this) {
+ pp::CompletionCallbackWithOutput<pp::NetworkListPrivate> callback =
+ callback_factory_.NewCallbackWithOutput(
+ &PepperNetworkManager::OnNetworkList);
+ monitor_.UpdateNetworkList(callback);
}
PepperNetworkManager::~PepperNetworkManager() {
@@ -43,18 +47,24 @@ void PepperNetworkManager::StopUpdating() {
--start_count_;
}
-// static
-void PepperNetworkManager::OnNetworkListCallbackHandler(
- void* user_data,
- PP_Resource list_resource) {
- PepperNetworkManager* object = static_cast<PepperNetworkManager*>(user_data);
- pp::NetworkListPrivate list(pp::PASS_REF, list_resource);
- object->OnNetworkList(list);
-}
-void PepperNetworkManager::OnNetworkList(const pp::NetworkListPrivate& list) {
+void PepperNetworkManager::OnNetworkList(int32_t result,
+ const pp::NetworkListPrivate& list) {
+ if (result != PP_OK) {
+ SignalError();
+ return;
+ }
+ DCHECK(!list.is_null());
+
network_list_received_ = true;
+ // Request for the next update.
+ pp::CompletionCallbackWithOutput<pp::NetworkListPrivate> callback =
+ callback_factory_.NewCallbackWithOutput(
+ &PepperNetworkManager::OnNetworkList);
+ monitor_.UpdateNetworkList(callback);
+
+ // Convert the networks to talk_base::Network.
std::vector<talk_base::Network*> networks;
size_t count = list.GetCount();
for (size_t i = 0; i < count; i++) {
« no previous file with comments | « remoting/client/plugin/pepper_network_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698