Issue 23453019: Allow uncacheable identifiers to go generic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23453019: Allow uncacheable identifiers to go generic. (Closed)

Created:
7 years, 3 months ago by Toon Verwaest

Modified:
7 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Allow uncacheable identifiers to go generic. BUG=v8:2867 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16481

Patch Set 3 : Addressed comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -26 lines)			Patch
M	src/ic.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	1 2	3 chunks	+27 lines, -23 lines	0 comments	Download
A +	test/mjsunit/regress/regress-store-uncacheable.js	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comment. https://chromiumcodereview.appspot.com/23453019/diff/2001/src/objects-inl.h File src/objects-inl.h (right): https://chromiumcodereview.appspot.com/23453019/diff/2001/src/objects-inl.h#newcode2652 src/objects-inl.h:2652: static bool IsIdentifier(UnicodeCache* cache, Name* name) ...

7 years, 3 months ago (2013-09-02 13:28:59 UTC) #2

Toon Verwaest

7 years, 3 months ago (2013-09-02 16:32:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r16481 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23453019: Allow uncacheable identifiers to go generic. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Adding test #

Patch Set 3 : Addressed comment #

Messages