src/ic.cc - Issue 23453019: Allow uncacheable identifiers to go generic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 23453019: Allow uncacheable identifiers to go generic. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comment Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index 2a1f83d9e47ac16c98f71c4504ff46457412e6e5..afce4f78a8f7fdd8462fe37884daad75dae65e80 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -1719,7 +1719,8 @@ MaybeObject* StoreIC::Store(State state,

// Strict mode doesn't allow setting non-existent global property.

return ReferenceError("not_defined", name);

} else if (FLAG_use_ic &&

- (lookup.IsNormal() ||

+ (!name->IsCacheable(isolate()) ||

+ lookup.IsNormal() ||

(lookup.IsField() && lookup.CanHoldValue(value)))) {

Handle<Code> stub = strict_mode == kStrictMode

? generic_stub_strict() : generic_stub();

« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »