Mirrors cleanup. No semantic changes.

Mirrors cleanup. No semantic changes.

BUG=
R=rmacnak@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27438

[Michael Lippautz (Google), 2013-09-11 23:04:10]

https://codereview.chromium.org/23451052/diff/1/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (left):

https://codereview.chromium.org/23451052/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:42: Map<Symbol, dynamic>
_convertStringToSymbolMap(Map<String, dynamic> map) {
unused

https://codereview.chromium.org/23451052/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:86: Map<Uri, LibraryMirror>
_createLibrariesMap(List<LibraryMirror> list) {
only 1 caller

[rmacnak, 2013-09-12 01:17:31]

LGTM with comments

https://chromiumcodereview.appspot.com/23451052/diff/3001/runtime/lib/mirrors...
File runtime/lib/mirrors_impl.dart (right):

https://chromiumcodereview.appspot.com/23451052/diff/3001/runtime/lib/mirrors...
runtime/lib/mirrors_impl.dart:24: Map _makeMemberMap(List mirrors) => new
Map.fromIterable(
Give type arguments to the constructor.

https://chromiumcodereview.appspot.com/23451052/diff/3001/runtime/lib/mirrors...
runtime/lib/mirrors_impl.dart:116: : this.libraries = new
Map.fromIterable(libraries, key: (e) => e.uri);
Ditto.

[Michael Lippautz (Google), 2013-09-12 01:31:15]

https://chromiumcodereview.appspot.com/23451052/diff/3001/runtime/lib/mirrors...
File runtime/lib/mirrors_impl.dart (right):

https://chromiumcodereview.appspot.com/23451052/diff/3001/runtime/lib/mirrors...
runtime/lib/mirrors_impl.dart:24: Map _makeMemberMap(List mirrors) => new
Map.fromIterable(
On 2013/09/12 01:17:31, Ryan Macnak wrote:
> Give type arguments to the constructor.

Done.

https://chromiumcodereview.appspot.com/23451052/diff/3001/runtime/lib/mirrors...
runtime/lib/mirrors_impl.dart:116: : this.libraries = new
Map.fromIterable(libraries, key: (e) => e.uri);
On 2013/09/12 01:17:31, Ryan Macnak wrote:
> Ditto.

Done.

[Michael Lippautz (Google), 2013-09-12 17:32:22]

Committed patchset #3 manually as r27438 (presubmit successful).