Re-enable TouchSelectionOriginatingFromWebpageTest with some fixes and logs

Re-enable TouchSelectionOriginatingFromWebpageTest with some fixes and logs

Re-enabled
TouchEditableImplAuraTest.TouchSelectionOriginatingFromWebpageTest with
two fixes:
 - Fixed calculations for selection rectangle after a touch selection
   handle is moved.
 - Added a wait between dragging the handle and getting the selection in
   the test to be sure that the selection is updated completely.
Also, added some logs in the test so that if it failed again, more data
is available for investigation.

BUG=276870
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220699

[mohsen, 2013-08-29 17:24:06]

Please take a look

[varunjain, 2013-08-30 16:52:08]

+sky for OWNERS
LGTM

https://chromiumcodereview.appspot.com/23449013/diff/1/ui/views/touchui/touch...
File ui/views/touchui/touch_selection_controller_impl.cc (right):

https://chromiumcodereview.appspot.com/23449013/diff/1/ui/views/touchui/touch...
ui/views/touchui/touch_selection_controller_impl.cc:196: drag_offset_ =
event->y() - cursor_height() +
While you are here, mind adding a comment on drag_offset_? You can refer to the
ASCII figure at the top of the file and say something like drag_offset_ is the
offset between scroll event position and the cursor position reported to the
client_view_.

[mohsen, 2013-08-30 18:26:39]

https://chromiumcodereview.appspot.com/23449013/diff/1/ui/views/touchui/touch...
File ui/views/touchui/touch_selection_controller_impl.cc (right):

https://chromiumcodereview.appspot.com/23449013/diff/1/ui/views/touchui/touch...
ui/views/touchui/touch_selection_controller_impl.cc:196: drag_offset_ =
event->y() - cursor_height() +
On 2013/08/30 16:52:08, varunjain wrote:
> While you are here, mind adding a comment on drag_offset_? You can refer to
the
> ASCII figure at the top of the file and say something like drag_offset_ is the
> offset between scroll event position and the cursor position reported to the
> client_view_.

Done.

[sky, 2013-08-30 19:52:50]

LGTM

https://chromiumcodereview.appspot.com/23449013/diff/7001/content/browser/web...
File content/browser/web_contents/touch_editable_impl_aura_browsertest.cc
(right):

https://chromiumcodereview.appspot.com/23449013/diff/7001/content/browser/web...
content/browser/web_contents/touch_editable_impl_aura_browsertest.cc:40:
LOG(INFO) << "TestTouchEditableImplAura::Reset()";
This is temporary, right? Please add a TODO to remove it.

[mohsen, 2013-08-30 20:03:56]

https://chromiumcodereview.appspot.com/23449013/diff/7001/content/browser/web...
File content/browser/web_contents/touch_editable_impl_aura_browsertest.cc
(right):

https://chromiumcodereview.appspot.com/23449013/diff/7001/content/browser/web...
content/browser/web_contents/touch_editable_impl_aura_browsertest.cc:40:
LOG(INFO) << "TestTouchEditableImplAura::Reset()";
On 2013/08/30 19:52:50, sky wrote:
> This is temporary, right? Please add a TODO to remove it.

Done.

[commit-bot: I haz the power, 2013-08-30 20:04:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mohsen@chromium.org/23449013/12001

[commit-bot: I haz the power, 2013-08-30 23:46:42]

Change committed as 220699