Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: ui/views/touchui/touch_selection_controller_impl.cc

Issue 23449013: Re-enable TouchSelectionOriginatingFromWebpageTest with some fixes and logs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added TODO for removing LOGs Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/touch_editable_impl_aura_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/touchui/touch_selection_controller_impl.cc
diff --git a/ui/views/touchui/touch_selection_controller_impl.cc b/ui/views/touchui/touch_selection_controller_impl.cc
index 8b6b35116c8cb117edee8b9d82fa3acf8a5cbb79..89f6bdcafa8799b209e8bf96536c634a16c0737c 100644
--- a/ui/views/touchui/touch_selection_controller_impl.cc
+++ b/ui/views/touchui/touch_selection_controller_impl.cc
@@ -193,7 +193,7 @@ class TouchSelectionControllerImpl::EditingHandleView
case ui::ET_GESTURE_SCROLL_BEGIN:
widget_->SetCapture(this);
controller_->SetDraggingHandle(this);
- drag_offset_ = event->y() - cursor_height() -
+ drag_offset_ = event->y() - cursor_height() +
kSelectionHandleVerticalDragOffset;
break;
case ui::ET_GESTURE_SCROLL_UPDATE: {
@@ -259,6 +259,10 @@ class TouchSelectionControllerImpl::EditingHandleView
scoped_ptr<Widget> widget_;
TouchSelectionControllerImpl* controller_;
gfx::Rect selection_rect_;
+
+ // Vertical offset between the scroll event position and the drag position
+ // reported to the client view (see the ASCII figure at the top of the file
+ // and its description for more details).
int drag_offset_;
// If set to true, the handle will not draw anything, hence providing an empty
« no previous file with comments | « content/browser/web_contents/touch_editable_impl_aura_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698