Issue 23447027: Merge 222390 "network_list.js should reflect the correct logged ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23447027: Merge 222390 "network_list.js should reflect the correct logged ..." (Closed)

Created:
7 years, 3 months ago by armansito

Modified:
7 years, 3 months ago

Reviewers:
armansito

CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1599/src/

Visibility:
Public.

More Reviews

Description

Merge 222390 "network_list.js should reflect the correct logged ..." > network_list.js should reflect the correct logged in user type. > > Updated InternetOptionsHandler and network_list.js to observe LoginState > updates, so that using UIAccountTweaks is not the only way to determine > whether or not the current user is owner. This is because |loadTimeData| > may not contain the current user login details if the logged in user type > updates after the UI fills in the UIAccountTweaks info. > > BUG=285589 > R=stevenjb@chromium.org > > Review URL: https://codereview.chromium.org/23466015 TBR=armansito@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222880

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -4 lines)			Patch
M	chrome/browser/resources/options/chromeos/network_list.js	View	3 chunks	+19 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/internet_options_handler.h	View	3 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc	View	6 chunks	+44 lines, -0 lines	0 comments	Download
M	chromeos/login/login_state.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/login/login_state.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r222880.

Expand Messages | Collapse Messages