Reduce chrome cras dbus call logs during device rebooting.

Reduce chrome cras dbus call logs during device rebooting. cras server won't start unitl after EmitLoginPromptVisible. Start cras log after it, so that we don't log the dbus failure due to cras call is made before it is started . Also a few other changes that should remove all other excess log seen during rebooting.

BUG=288177

[Daniel Erat, 2013-09-12 20:39:30]

https://codereview.chromium.org/23444057/diff/1/chromeos/audio/cras_audio_han...
File chromeos/audio/cras_audio_handler.cc (right):

https://codereview.chromium.org/23444057/diff/1/chromeos/audio/cras_audio_han...
chromeos/audio/cras_audio_handler.cc:351: // During device reboot, cras may
change active input to unknown device 0x1,
is "device reboot" the right phrase here, or do you mean "system boot"?

https://codereview.chromium.org/23444057/diff/1/chromeos/audio/cras_audio_han...
chromeos/audio/cras_audio_handler.cc:365: // During device reboot, cras may
change active input to unknown device 0x2,
same here

https://codereview.chromium.org/23444057/diff/1/chromeos/audio/cras_audio_han...
chromeos/audio/cras_audio_handler.cc:395: << "Can't set up audio state for
unknow input device id ="
nit: s/unknow/unknown/

https://codereview.chromium.org/23444057/diff/1/chromeos/audio/cras_audio_han...
chromeos/audio/cras_audio_handler.cc:410: << "Can't set up audio state for
unknow output device id ="
nit: s/unknow/unknown/

https://codereview.chromium.org/23444057/diff/1/chromeos/dbus/cras_audio_clie...
File chromeos/dbus/cras_audio_client.cc (right):

https://codereview.chromium.org/23444057/diff/1/chromeos/dbus/cras_audio_clie...
chromeos/dbus/cras_audio_client.cc:20: "org.chromium.cras.Error.NoResponse";
could you add a comment documenting where this string came from? is it just
something invented for errors where cras doesn't respond?

[jennyz, 2013-09-12 21:00:04]

https://codereview.chromium.org/23444057/diff/1/chromeos/audio/cras_audio_han...
File chromeos/audio/cras_audio_handler.cc (right):

https://codereview.chromium.org/23444057/diff/1/chromeos/audio/cras_audio_han...
chromeos/audio/cras_audio_handler.cc:351: // During device reboot, cras may
change active input to unknown device 0x1,
On 2013/09/12 20:39:31, Daniel Erat wrote:
> is "device reboot" the right phrase here, or do you mean "system boot"?

Done.

https://codereview.chromium.org/23444057/diff/1/chromeos/audio/cras_audio_han...
chromeos/audio/cras_audio_handler.cc:365: // During device reboot, cras may
change active input to unknown device 0x2,
On 2013/09/12 20:39:31, Daniel Erat wrote:
> same here

Done.

https://codereview.chromium.org/23444057/diff/1/chromeos/audio/cras_audio_han...
chromeos/audio/cras_audio_handler.cc:395: << "Can't set up audio state for
unknow input device id ="
On 2013/09/12 20:39:31, Daniel Erat wrote:
> nit: s/unknow/unknown/

Done.

https://codereview.chromium.org/23444057/diff/1/chromeos/audio/cras_audio_han...
chromeos/audio/cras_audio_handler.cc:410: << "Can't set up audio state for
unknow output device id ="
On 2013/09/12 20:39:31, Daniel Erat wrote:
> nit: s/unknow/unknown/

Done.

https://codereview.chromium.org/23444057/diff/1/chromeos/dbus/cras_audio_clie...
File chromeos/dbus/cras_audio_client.cc (right):

https://codereview.chromium.org/23444057/diff/1/chromeos/dbus/cras_audio_clie...
chromeos/dbus/cras_audio_client.cc:20: "org.chromium.cras.Error.NoResponse";
On 2013/09/12 20:39:31, Daniel Erat wrote:
> could you add a comment documenting where this string came from? is it just
> something invented for errors where cras doesn't respond?

Done.

[Daniel Erat, 2013-09-12 21:10:05]

https://codereview.chromium.org/23444057/diff/7001/chromeos/audio/cras_audio_...
File chromeos/audio/cras_audio_handler.cc (right):

https://codereview.chromium.org/23444057/diff/7001/chromeos/audio/cras_audio_...
chromeos/audio/cras_audio_handler.cc:379: enable_log_ = true;
what happens if chrome crashes and is restarted? i assume that
EmitLoginPromptVisibleCalled() will never run in that case -- will enable_log_
be stuck at false?

https://codereview.chromium.org/23444057/diff/7001/chromeos/audio/cras_audio_...
File chromeos/audio/cras_audio_handler.h (right):

https://codereview.chromium.org/23444057/diff/7001/chromeos/audio/cras_audio_...
chromeos/audio/cras_audio_handler.h:260: bool enable_log_;
nit: add a brief comment like:

// Failures are not logged at startup, since CRAS may not be running yet.

[jennyz, 2013-09-12 22:34:44]

https://codereview.chromium.org/23444057/diff/7001/chromeos/audio/cras_audio_...
File chromeos/audio/cras_audio_handler.cc (right):

https://codereview.chromium.org/23444057/diff/7001/chromeos/audio/cras_audio_...
chromeos/audio/cras_audio_handler.cc:379: enable_log_ = true;
On 2013/09/12 21:10:05, Daniel Erat wrote:
> what happens if chrome crashes and is restarted? i assume that
> EmitLoginPromptVisibleCalled() will never run in that case -- will enable_log_
> be stuck at false?

Good pointed, enable CrasAudioHandler logging when chrome restarts after
crashing.

https://codereview.chromium.org/23444057/diff/7001/chromeos/audio/cras_audio_...
File chromeos/audio/cras_audio_handler.h (right):

https://codereview.chromium.org/23444057/diff/7001/chromeos/audio/cras_audio_...
chromeos/audio/cras_audio_handler.h:260: bool enable_log_;
On 2013/09/12 21:10:05, Daniel Erat wrote:
> nit: add a brief comment like:
> 
> // Failures are not logged at startup, since CRAS may not be running yet.

Done.

[Daniel Erat, 2013-09-12 22:47:03]

lgtm

https://codereview.chromium.org/23444057/diff/1010/chromeos/audio/cras_audio_...
File chromeos/audio/cras_audio_handler.h (right):

https://codereview.chromium.org/23444057/diff/1010/chromeos/audio/cras_audio_...
chromeos/audio/cras_audio_handler.h:264: bool enable_log_;
nit: sorry for not mentioning this earlier, but do you mind changing this to
log_errors_ (and also renaming the method to LogErrors())? i think it makes it a
bit more clear what they do.

[jennyz, 2013-09-12 23:48:24]

After I rebased and tried to upload the new patch for renaming EnableLog() to
LogErrors(), somehow, git just think the base files are missing, and won't
upload the patch, therefore, I updated a new cl. The only difference between the
new cl and this one is to rename EnableLog to LogErrors as you suggested. Here
is the new cl, PTAL.
https://codereview.chromium.org/23460038/

Thanks,

https://codereview.chromium.org/23444057/diff/1010/chromeos/audio/cras_audio_...
File chromeos/audio/cras_audio_handler.h (right):

https://codereview.chromium.org/23444057/diff/1010/chromeos/audio/cras_audio_...
chromeos/audio/cras_audio_handler.h:264: bool enable_log_;
On 2013/09/12 22:47:03, Daniel Erat wrote:
> nit: sorry for not mentioning this earlier, but do you mind changing this to
> log_errors_ (and also renaming the method to LogErrors())? i think it makes it
a
> bit more clear what they do.

Done.