Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2886)

Unified Diff: chrome/browser/extensions/api/audio/audio_service_chromeos.cc

Issue 23444057: Reduce chrome cras dbus call logs during device rebooting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename EnableLog Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/chrome_browser_main_chromeos.cc ('k') | chromeos/audio/cras_audio_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/audio/audio_service_chromeos.cc
diff --git a/chrome/browser/extensions/api/audio/audio_service_chromeos.cc b/chrome/browser/extensions/api/audio/audio_service_chromeos.cc
index 7485b19d747119a6a4ab46e1307303167ad18f87..abce101b1c3e9197ff88c972b726b90d07ae5b1b 100644
--- a/chrome/browser/extensions/api/audio/audio_service_chromeos.cc
+++ b/chrome/browser/extensions/api/audio/audio_service_chromeos.cc
@@ -57,6 +57,10 @@ class AudioServiceImpl : public AudioService,
const chromeos::AudioNodeList& audio_nodes,
bool success);
+ // ErrorCallback for CrasAudioClient::GetNodes().
+ void OnGetNodesError(const std::string& error_name,
+ const std::string& error_msg);
+
bool FindDevice(uint64 id, chromeos::AudioDevice* device);
uint64 GetIdFromStr(const std::string& id_str);
@@ -105,10 +109,14 @@ void AudioServiceImpl::RemoveObserver(AudioService::Observer* observer) {
void AudioServiceImpl::StartGetInfo(const GetInfoCallback& callback) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(cras_audio_client_);
+ // TODO(jennyz,rkc): Replace cras_audio_client_ call with CrasAudioHandler
+ // Api call.
if (cras_audio_client_)
cras_audio_client_->GetNodes(base::Bind(&AudioServiceImpl::OnGetNodes,
weak_ptr_factory_.GetWeakPtr(),
- callback));
+ callback),
+ base::Bind(&AudioServiceImpl::OnGetNodesError,
+ weak_ptr_factory_.GetWeakPtr()));
}
void AudioServiceImpl::SetActiveDevices(const DeviceIdList& device_list) {
@@ -195,6 +203,10 @@ void AudioServiceImpl::OnGetNodes(const GetInfoCallback& callback,
callback.Run(output_info, input_info, success);
}
+void AudioServiceImpl::OnGetNodesError(const std::string& error_name,
+ const std::string& error_msg) {
+}
+
bool AudioServiceImpl::FindDevice(uint64 id, chromeos::AudioDevice* device) {
chromeos::AudioDeviceList devices;
cras_audio_handler_->GetAudioDevices(&devices);
« no previous file with comments | « chrome/browser/chromeos/chrome_browser_main_chromeos.cc ('k') | chromeos/audio/cras_audio_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698