Issue 23441050: Add driver bug workaround for SH_INIT_GL_POSITION.

Issue 23441050: Add driver bug workaround for SH_INIT_GL_POSITION. (Closed)

Created:
7 years, 3 months ago by Zhenyao Mo

Modified:
7 years, 3 months ago

Reviewers:
Ken Russell (switch to Gerrit), bajones

CC:
chromium-reviews, piman+watch_chromium.org, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add driver bug workaround for SH_INIT_GL_POSITION. BUG=286468 TEST=webgl conformance tests (1.0.3), gpu_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221895

Patch Set 2 : change int to ShCompileOptions #

Patch Set 4 : update #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -49 lines)			Patch
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 2	2 chunks	+10 lines, -6 lines	0 comments	Download
M	gpu/command_buffer/service/mocks.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/service/shader_translator.h	View	1	4 chunks	+3 lines, -8 lines	0 comments	Download
M	gpu/command_buffer/service/shader_translator.cc	View	1	4 chunks	+4 lines, -7 lines	0 comments	Download
M	gpu/command_buffer/service/shader_translator_cache.h	View	1	3 chunks	+4 lines, -7 lines	0 comments	Download
M	gpu/command_buffer/service/shader_translator_cache.cc	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/service/shader_translator_unittest.cc	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	gpu/config/gpu_driver_bug_list_json.cc	View	1 2 3	2 chunks	+13 lines, -1 line	0 comments	Download
M	gpu/config/gpu_driver_bug_workaround_type.h	View	1 2 3	3 chunks	+12 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Zhenyao Mo

Please take a look. Tested locally on my linux NVIDIA with ToT ANGLE, tests are ...

7 years, 3 months ago (2013-09-06 21:42:43 UTC) #1

Ken Russell (switch to Gerrit)

LGTM with one issue addressed. https://codereview.chromium.org/23441050/diff/1/gpu/command_buffer/service/shader_translator.h File gpu/command_buffer/service/shader_translator.h (right): https://codereview.chromium.org/23441050/diff/1/gpu/command_buffer/service/shader_translator.h#newcode123 gpu/command_buffer/service/shader_translator.h:123: int driver_bug_workarounds) OVERRIDE; Could ...

7 years, 3 months ago (2013-09-06 21:57:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/23441050/16001

7 years, 3 months ago (2013-09-07 01:33:28 UTC) #4

Message was sent while issue was closed.

Change committed as 221895

Expand Messages | Collapse Messages